View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001870 | ardour | bugs | public | 2007-09-16 08:57 | 2020-04-19 20:12 |
| Reporter | esaracco | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0001870: [PATCH] After opening new session, track comments windows of precedent session are still open | ||||
| Description | Hi, After opening new session, track comments windows of precedent session are still open. Not really nasty: perhaps should be "cosmetic"... Bye | ||||
| Additional Information | To reproduce it: * Open a session. * Open some track comment. * Open a new session. -> Comment windows are still open. | ||||
| Tags | No tags attached. | ||||
|
|
Still present in 2.0-ongoing. |
|
|
Fixed in 3.0 rev 5831. |
|
2009-10-20 23:04
|
1870.patch (450 bytes)
diff --git a/gtk2_ardour/mixer_strip.cc b/gtk2_ardour/mixer_strip.cc
index 4861efd..9212b6c 100644
--- a/gtk2_ardour/mixer_strip.cc
+++ b/gtk2_ardour/mixer_strip.cc
@@ -300,13 +300,9 @@ MixerStrip::~MixerStrip ()
{
GoingAway(); /* EMIT_SIGNAL */
- if (input_selector) {
- delete input_selector;
- }
-
- if (output_selector) {
- delete output_selector;
- }
+ delete input_selector;
+ delete output_selector;
+ delete comment_window;
}
void
|
|
|
Attached patch for 2.0-ongoing (with a couple of removals of unnecessary checks for null) |
|
|
tested and applied patch on 2.8.3 SVN, rev 5847 |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-09-16 08:57 | esaracco | New Issue | |
| 2009-10-20 22:32 | cth103 | Note Added: 0006805 | |
| 2009-10-20 22:32 | cth103 | Status | new => confirmed |
| 2009-10-20 22:59 | cth103 | Note Added: 0006806 | |
| 2009-10-20 23:04 | cth103 | File Added: 1870.patch | |
| 2009-10-20 23:04 | cth103 | Note Added: 0006809 | |
| 2009-10-20 23:04 | cth103 | Status | confirmed => assigned |
| 2009-10-20 23:04 | cth103 | Assigned To | => paul |
| 2009-10-20 23:04 | cth103 | cost | => 0.00 |
| 2009-10-20 23:04 | cth103 | Summary | After opening new session, track comments windows of precedent session are still open => [PATCH] After opening new session, track comments windows of precedent session are still open |
| 2009-10-20 23:05 | cth103 | Note Edited: 0006809 | |
| 2009-10-21 19:16 | BenLoftis | Note Added: 0006846 | |
| 2009-10-22 01:54 | cth103 | Status | assigned => resolved |
| 2009-10-22 01:54 | cth103 | Resolution | open => fixed |
| 2020-04-19 20:12 | system | Note Added: 0021558 | |
| 2020-04-19 20:12 | system | Status | resolved => closed |
