View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001853 | ardour | bugs | public | 2007-09-03 18:42 | 2008-11-21 00:04 |
| Reporter | jdavisp3 | Assigned To | timbyr | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.0 | ||||
| Summary | 0001853: selecting existing session to open does not always work | ||||
| Description | If you select an existing session by typing in the fullpath rather than mousing, ardour looks for it in the wrong directory. This is similar to bug 1852 and has a similar fix. A patch is attached, relative to the 1852 patch. | ||||
| Tags | No tags attached. | ||||
|
2007-09-03 18:42
|
ardour2.patch (626 bytes)
--- /tmp/new_session_dialog.cc 2007-09-03 10:44:43.000000000 -0700
+++ gtk2_ardour/new_session_dialog.cc 2007-09-03 11:35:24.000000000 -0700
@@ -468,7 +468,8 @@
return Glib::filename_from_utf8(m_folder->get_filename());
} else {
if (m_treeview->get_selection()->count_selected_rows() == 0) {
- return Glib::filename_from_utf8(m_open_filechooser->get_current_folder());
+ std::string str = Glib::filename_from_utf8(m_open_filechooser->get_filename());
+ return Glib::path_get_dirname(str);
}
Gtk::TreeModel::iterator i = m_treeview->get_selection()->get_selected();
return (*i)[recent_columns.fullpath];
|
|
|
Patch committed to trunk as r2419 |
|
|
The change to the trunk isn't quite right. I'll add a patch. |
|
2007-09-13 15:32
|
ardour-2.0.patch (938 bytes)
Index: gtk2_ardour/new_session_dialog.cc
===================================================================
--- gtk2_ardour/new_session_dialog.cc (revision 2464)
+++ gtk2_ardour/new_session_dialog.cc (working copy)
@@ -506,12 +506,12 @@
std::string
NewSessionDialog::session_folder() const
{
- if (m_notebook->get_current_page() == 0) {
- return Glib::filename_from_utf8(m_folder->get_filename());
+ if (m_notebook->get_current_page() == 0) {
+ return Glib::filename_from_utf8(m_folder->get_filename());
} else {
-
if (m_treeview->get_selection()->count_selected_rows() == 0) {
- return Glib::filename_from_utf8(m_open_filechooser->get_filename());
+ std::string str = Glib::filename_from_utf8(m_open_filechooser->get_filename());
+ return Glib::path_get_dirname(str);
}
Gtk::TreeModel::iterator i = m_treeview->get_selection()->get_selected();
return (*i)[recent_columns.fullpath];
|
|
|
Err, I meant the change to 2.0-ongoing, not the trunk. |
|
|
I believe you reopened the wrong bug. As I understand it two basically identical bug reports were created, one for the 2.0-ongoing branch(1852) and one for the trunk branch(1853). Anyway, this issue should now be fixed in both branches. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-09-03 18:42 | jdavisp3 | New Issue | |
| 2007-09-03 18:42 | jdavisp3 | File Added: ardour2.patch | |
| 2007-09-05 02:14 | timbyr | Status | new => assigned |
| 2007-09-05 02:14 | timbyr | Assigned To | => timbyr |
| 2007-09-05 02:20 | timbyr | Status | assigned => resolved |
| 2007-09-05 02:20 | timbyr | Resolution | open => fixed |
| 2007-09-05 02:20 | timbyr | Note Added: 0004334 | |
| 2007-09-13 15:32 | jdavisp3 | Status | resolved => feedback |
| 2007-09-13 15:32 | jdavisp3 | Resolution | fixed => reopened |
| 2007-09-13 15:32 | jdavisp3 | Note Added: 0004363 | |
| 2007-09-13 15:32 | jdavisp3 | File Added: ardour-2.0.patch | |
| 2007-09-13 15:33 | jdavisp3 | Note Added: 0004364 | |
| 2007-09-19 01:51 | timbyr | Status | feedback => resolved |
| 2007-09-19 01:51 | timbyr | Resolution | reopened => fixed |
| 2007-09-19 01:51 | timbyr | Note Added: 0004379 | |
| 2008-11-21 00:04 | seablade | Status | resolved => closed |
