View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001827 | ardour | bugs | public | 2007-08-12 05:26 | 2008-11-21 00:04 |
| Reporter | jdavisp3 | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.0 | ||||
| Summary | 0001827: bug selecting end of region with 'region boundary' snap type | ||||
| Description | If the start of the last region occurs before the end of the second-to-last region, the end of the last region cannot be selected with 'region boundary' snap type selected. The attached patch is my proposed fix. | ||||
| Tags | No tags attached. | ||||
|
2007-08-12 05:26
|
ardour.patch (612 bytes)
Index: gtk2_ardour/editor_ops.cc
===================================================================
--- gtk2_ardour/editor_ops.cc (revision 2289)
+++ gtk2_ardour/editor_ops.cc (working copy)
@@ -497,12 +497,13 @@
for (vector<RegionPoint>::iterator p = interesting_points.begin(); p != interesting_points.end(); ++p) {
if ((r = find_next_region (pos, *p, 1, tlist, &ontrack)) == 0) {
- at_end = true;
+ if (*p == interesting_points.back()) {
+ at_end = true;
+ }
/* move to next point type */
continue;
}
-
switch (*p) {
case Start:
rpos = r->first_frame();
|
|
2007-09-22 23:52
|
ardour-2.0.patch (612 bytes)
Index: gtk2_ardour/editor_ops.cc
===================================================================
--- gtk2_ardour/editor_ops.cc (revision 2475)
+++ gtk2_ardour/editor_ops.cc (working copy)
@@ -525,12 +525,13 @@
for (vector<RegionPoint>::iterator p = interesting_points.begin(); p != interesting_points.end(); ++p) {
if ((r = find_next_region (pos, *p, 1, tlist, &ontrack)) == 0) {
- at_end = true;
+ if (*p == interesting_points.back()) {
+ at_end = true;
+ }
/* move to next point type */
continue;
}
-
switch (*p) {
case Start:
rpos = r->first_frame();
|
|
|
patches applied to my codebase, and will be in the upcoming 2.1 release. thanks again. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-08-12 05:26 | jdavisp3 | New Issue | |
| 2007-08-12 05:26 | jdavisp3 | File Added: ardour.patch | |
| 2007-09-22 23:52 | jdavisp3 | File Added: ardour-2.0.patch | |
| 2007-09-27 16:11 | paul | Status | new => resolved |
| 2007-09-27 16:11 | paul | Resolution | open => fixed |
| 2007-09-27 16:11 | paul | Assigned To | => paul |
| 2007-09-27 16:11 | paul | Note Added: 0004423 | |
| 2008-11-21 00:04 | seablade | Status | resolved => closed |
