View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001823ardourbugspublic2007-08-08 23:272008-11-21 00:28
Reporterrtp405 Assigned Totimbyr  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version2.0 
Summary0001823: Selecting session file as template causes segmentation fault
DescriptionArdour 2.0.2

This is a design issue, i guess. And it's an ugly one.

1. create new session
2. save as template
3. create new session, from template, but navigate to the Ardour session upon which the template is based and select the .ardour file to
base the new session on

It might seem stupid but it's an easy mistake to make.

All kinds of bad comes from this; sessions that seqfault when attempting to open and the worst sessions that open, appear to record data but have nothing in them when reopened and most enbarrasing, compensating the client to the tune of three musicans * $50.00 an hour + $50.00 an hour studio rate. AFAIC, it's the developers job to keep me from being this stupid. So, how 'bout you gets my shit together!
TagsNo tags attached.

Activities

2007-08-16 04:41

 

0001-Restrict-template-filechooser-filter-to-only-display.patch (942 bytes)    
From 332895cafb834f7643c795dc90a90142eef6a63b Mon Sep 17 00:00:00 2001
From: Tim Mayberry <mojofunk@gmail.com>
Date: Thu, 16 Aug 2007 14:39:29 +1000
Subject: [PATCH] Restrict template filechooser filter to only display template files. Fixes bug 1823.

---
 gtk2_ardour/new_session_dialog.cc |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/gtk2_ardour/new_session_dialog.cc b/gtk2_ardour/new_session_dialog.cc
index 43f98a5..6c6e56a 100644
--- a/gtk2_ardour/new_session_dialog.cc
+++ b/gtk2_ardour/new_session_dialog.cc
@@ -389,8 +389,6 @@ NewSessionDialog::NewSessionDialog()
 	m_open_filechooser->set_title(_("select session file"));
 
 	Gtk::FileFilter* template_filter = manage (new (Gtk::FileFilter));
-	template_filter->add_pattern(X_("*.ardour"));
-	template_filter->add_pattern(X_("*.ardour.bak"));
 	template_filter->add_pattern(X_("*.template"));
 	m_template->set_filter (*template_filter);
 
-- 
1.5.2.2
0001-Restrict-template-filechooser-filter-to-only-display.patch (942 bytes)   

timbyr

2007-08-16 05:54

developer   ~0004272

I've attached a patch that restricts the filechooser to only allow selection of files with the *.template extension.

I don't think Session(*.ardour) files were ever intended to be used as templates.

timbyr

2007-08-20 00:21

developer   ~0004276

Last edited: 2007-08-20 00:22

 I had some positive feedback from the reporter in IRC so I'll commit the attached patch to trunk in the next few days.

timbyr

2007-08-27 11:32

developer   ~0004300

I've committed the patch to trunk as svn rev 2348 so I'm going to mark this issue as resolved.

The commit should apply to the release branch but I'll leave that up to the manager of that branch to commit it, if they do it should be fixed in the next release.

Issue History

Date Modified Username Field Change
2007-08-08 23:27 rtp405 New Issue
2007-08-16 04:41 timbyr Status new => assigned
2007-08-16 04:41 timbyr Assigned To => timbyr
2007-08-16 04:41 timbyr File Added: 0001-Restrict-template-filechooser-filter-to-only-display.patch
2007-08-16 04:45 timbyr Severity major => minor
2007-08-16 04:45 timbyr Category features => bugs
2007-08-16 04:45 timbyr Summary create new session from template => Selecting session file as template causes segmentation fault
2007-08-16 05:54 timbyr Note Added: 0004272
2007-08-16 05:54 timbyr Status assigned => feedback
2007-08-20 00:21 timbyr Note Added: 0004276
2007-08-20 00:21 timbyr Status feedback => assigned
2007-08-20 00:22 timbyr Note Edited: 0004276
2007-08-27 11:32 timbyr Note Added: 0004300
2007-08-27 11:33 timbyr Status assigned => resolved
2007-08-27 11:33 timbyr Resolution open => fixed
2008-11-21 00:28 seablade Status resolved => closed