View Issue Details

IDProjectCategoryView StatusLast Update
0001816ardourbugspublic2008-11-21 00:28
Reporterjdavisp3 Assigned Topaul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0001816: saving template while not connected to jack crashes ardour
DescriptionSaving a template when not connected to jack results this message:

AudioEngine::frame_rate() called while disconnected from JACK

And then ardour exits immediately.

Attached is a patch to call the check_audioengine function
as several other methods already do before saving the template.
TagsNo tags attached.

Activities

2007-08-06 01:54

 

patch (464 bytes)   
Index: gtk2_ardour/ardour_ui.cc
===================================================================
--- gtk2_ardour/ardour_ui.cc	(revision 2252)
+++ gtk2_ardour/ardour_ui.cc	(working copy)
@@ -1813,6 +1813,10 @@
 	ArdourPrompter prompter (true);
 	string name;
 
+	if (!check_audioengine()) {
+		return;
+	}
+
 	prompter.set_name (X_("Prompter"));
 	prompter.set_prompt (_("Name for mix template:"));
 	prompter.set_initial_text(session->name() + _("-template"));
patch (464 bytes)   

nowhiskey

2007-08-06 09:07

reporter   ~0004238

hallo, i am able to reproduce this behavior, when patch applied, i get the message that 'Ardour is not connected to JACK
You cannot open or close sessions in this condition'.
so, it seems that the patch works, but would it not be better if we could make a template, with ardour disconnected from jack too?

if someone needs, i can attach the coredump i get when trying this action before applying the patch.

cheers,
doc

paul

2007-08-06 14:31

administrator   ~0004239

applied to 2.0-ongoing and in my tree for trunk. thanks very much!

Issue History

Date Modified Username Field Change
2007-08-06 01:54 jdavisp3 New Issue
2007-08-06 01:54 jdavisp3 File Added: patch
2007-08-06 09:07 nowhiskey Note Added: 0004238
2007-08-06 14:31 paul Status new => resolved
2007-08-06 14:31 paul Resolution open => fixed
2007-08-06 14:31 paul Assigned To => paul
2007-08-06 14:31 paul Note Added: 0004239
2008-11-21 00:28 seablade Status resolved => closed