View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001807 | ardour | features | public | 2007-08-03 21:00 | 2007-08-22 21:17 |
| Reporter | oofus | Assigned To | paul | ||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Centrino 1.6GHz Laptop | OS | Linux | OS Version | Mandriva 2007 |
| Summary | 0001807: Allow MMC IDs to be set for both sending and receiving | ||||
| Description | Allow MMC IDs to be set for both sending and receiving. ie independent settings for the ID that Ardour sends MMC messages to and the ID that Ardour responds to when receiving MMC messages. Should be set to 0x7F (all call) by default. | ||||
| Tags | No tags attached. | ||||
|
|
implemented in branches/2.0-ongoing (and will be ported to trunk). not usefully tested. |
|
|
Excellent, thank for this. Initially I see that the defaults are '0' in the options editor not '127' ('0x7F') Will test more fully later. |
|
|
MMC messages are sent to ID 0x7F regardless of what is set in the options editor. ID so set are not remembered between session re-loads. |
|
|
Messages are now sent and received to/from the correct set IDs. Default is still 0 not 127 and the IDs are not saved. |
|
|
Current state is, messages are sent/received with the correct ID and those IDs appear to be saved and recalled. The display in the options editor, however, always shows 0 for the IDs until the IDs are changed again manualy. |
|
2007-08-10 22:41
|
MMC_Persistant_ID_Display.patch (1,098 bytes)
Index: option_editor.cc
===================================================================
--- option_editor.cc (revision 2282)
+++ option_editor.cc (working copy)
@@ -375,8 +375,10 @@
label = (manage (new Label (_("Inbound MMC Device ID"))));
hbox->pack_start (mmc_receive_device_id_spinner, false, false);
hbox->pack_start (*label, false, false);
- midi_packer.pack_start (*hbox, false, false);
+ midi_packer.pack_start (*hbox, false, false);
+ mmc_receive_device_id_spinner.set_value(Config->get_mmc_receive_device_id ());
+
hbox = manage (new HBox);
hbox->set_border_width (6);
hbox->set_spacing (6);
@@ -385,6 +387,8 @@
hbox->pack_start (*label, false, false);
midi_packer.pack_start (*hbox, false, false);
+ mmc_send_device_id_spinner.set_value(Config->get_mmc_send_device_id ());
+
add_midi_port_button.signal_clicked().connect (mem_fun (*this, &OptionEditor::add_midi_port));
}
@@ -713,8 +717,6 @@
{
uint8_t id = (uint8_t) mmc_send_device_id_spinner.get_value();
- cerr << "New send ID = " << (int) id << endl;
-
Config->set_mmc_send_device_id (id);
}
|
|
|
Attached a patch to fix the last little issue, IDs not being shown initially in the options editor. Hope this is the right way to do. It seems to work ! Patch is against ongoing 2282 |
|
2007-08-11 10:36
|
MMC_Persistant_ID_Display2.patch (1,134 bytes)
Index: gtk2_ardour/option_editor.cc
===================================================================
--- gtk2_ardour/option_editor.cc (revision 2290)
+++ gtk2_ardour/option_editor.cc (working copy)
@@ -375,8 +375,10 @@
label = (manage (new Label (_("Inbound MMC Device ID"))));
hbox->pack_start (mmc_receive_device_id_spinner, false, false);
hbox->pack_start (*label, false, false);
- midi_packer.pack_start (*hbox, false, false);
+ midi_packer.pack_start (*hbox, false, false);
+ mmc_receive_device_id_spinner.set_value(Config->get_mmc_receive_device_id ());
+
hbox = manage (new HBox);
hbox->set_border_width (6);
hbox->set_spacing (6);
@@ -385,6 +387,8 @@
hbox->pack_start (*label, false, false);
midi_packer.pack_start (*hbox, false, false);
+ mmc_send_device_id_spinner.set_value(Config->get_mmc_send_device_id ());
+
add_midi_port_button.signal_clicked().connect (mem_fun (*this, &OptionEditor::add_midi_port));
}
@@ -713,8 +717,6 @@
{
uint8_t id = (uint8_t) mmc_send_device_id_spinner.get_value();
- cerr << "New send ID = " << (int) id << endl;
-
Config->set_mmc_send_device_id (id);
}
|
|
|
OK, uploaded the correct patch this time, ending in ...Display2.patch. Files at the correct levels now. |
|
|
patch applied to 2.0-ongoing and trunk. commit to follow. |
|
|
feature implemented. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-08-03 21:00 | oofus | New Issue | |
| 2007-08-04 14:40 | paul | Note Added: 0004228 | |
| 2007-08-04 19:42 | oofus | Note Added: 0004230 | |
| 2007-08-04 19:59 | oofus | Note Edited: 0004230 | |
| 2007-08-04 20:00 | oofus | Note Added: 0004231 | |
| 2007-08-07 10:35 | oofus | Note Added: 0004241 | |
| 2007-08-08 09:53 | oofus | Note Added: 0004243 | |
| 2007-08-10 22:41 | oofus | File Added: MMC_Persistant_ID_Display.patch | |
| 2007-08-10 22:43 | oofus | Note Added: 0004262 | |
| 2007-08-11 10:29 | oofus | Note Edited: 0004262 | |
| 2007-08-11 10:36 | oofus | File Added: MMC_Persistant_ID_Display2.patch | |
| 2007-08-11 10:37 | oofus | Note Added: 0004263 | |
| 2007-08-22 14:35 | paul | Status | new => resolved |
| 2007-08-22 14:35 | paul | Resolution | open => fixed |
| 2007-08-22 14:35 | paul | Assigned To | => paul |
| 2007-08-22 14:35 | paul | Note Added: 0004282 | |
| 2007-08-22 21:17 | oofus | Status | resolved => closed |
| 2007-08-22 21:17 | oofus | Note Added: 0004283 |
