View Issue Details

IDProjectCategoryView StatusLast Update
0001764ardourbugspublic2007-07-31 02:04
Reportertimbyr Assigned Totimbyr  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0001764: powermate surface module install path is incorrect for x86_64
DescriptionIt is installed into $PREFIX/lib/ardour2/surfaces on both x86 and x86_64.

I think it should be $PREFIX/lib64/ardour2/surfaces for x86_64, well this might not be true for all systems but it is inline with how the other modules are installed.

I've attached a patch against 2.0-ongoing@2127 rather than trunk as it looks like there has been a fix committed to the 2.0-ongoing branch but only partially to trunk which results in patch not applying to trunk.

More specifically the changes in commit 2096 to the /libs/surfaces/powermate/SConscript file in the 2.0-ongoing branch did not get applied to trunk in commit 2101 even though the changes to SConstruct in commit 2096 were included.

To apply this patch to trunk something silly like this should work.

$svn diff http://subversion.ardour.org/svn/ardour2/branches/2.0-ongoing/libs/surfaces/powermate/SConscript@2095 http://subversion.ardour.org/svn/ardour2/branches/2.0-ongoing/libs/surfaces/powermate/SConscript@2096 | patch libs/surfaces/powermate/SConscript && patch -p0 < powermate-multilib-install-fix.patch
TagsNo tags attached.

Activities

2007-07-13 02:49

 

powermate-multilib-install-fix.patch (639 bytes)   
Index: libs/surfaces/powermate/SConscript
===================================================================
--- libs/surfaces/powermate/SConscript	(revision 2127)
+++ libs/surfaces/powermate/SConscript	(working copy)
@@ -50,7 +50,7 @@
     if env['NLS']:
 	    i18n (powermate, powermate_files, env)
 	      
-    env.Alias('install', env.Install(os.path.join(install_prefix, 'lib/ardour2/surfaces'), libardour_powermate))
+    env.Alias('install', env.Install(os.path.join(install_prefix, env['LIBDIR'], 'ardour2', 'surfaces'), libardour_powermate))
 
 env.Alias('tarball', env.Distribute (env['DISTTREE'],
 				     [ 'SConscript' ] +

timbyr

2007-07-31 02:04

developer   ~0004204

A fix for this issue was commited to the 2.0-ongoing branch as svn rev 2194 and to the trunk branch as rev 2195

Issue History

Date Modified Username Field Change
2007-07-13 02:49 timbyr New Issue
2007-07-13 02:49 timbyr File Added: powermate-multilib-install-fix.patch
2007-07-31 02:04 timbyr Status new => resolved
2007-07-31 02:04 timbyr Resolution open => fixed
2007-07-31 02:04 timbyr Assigned To => timbyr
2007-07-31 02:04 timbyr Note Added: 0004204
2007-07-31 02:04 timbyr Status resolved => closed