View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001692 | ardour | bugs | public | 2007-05-22 08:23 | 2020-04-19 20:12 |
| Reporter | SaBer | Assigned To | cth103 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.0 | ||||
| Summary | 0001692: Having a track named 'click' causes its output routing to get messed up | ||||
| Description | Steps to reproduce: 1. create new session 2. create new track 3. rename track to 'click' 4. open track/bus inspector and try to add/remove the master bus as an output | ||||
| Tags | No tags attached. | ||||
|
|
The same happens with the name 'auditioner' |
|
|
I have never coded a single line of c++, but I think I found a potential fix for this: in visual_time_axis.cc, function start_time_axis_rename (line 339) replace "if (editor.get_named_time_axis(result) != 0) {" with "if (_session.route_name_unique(result) == 1) {" I think this would cause Ardour to tell you a track with that name already exists, when trying to rename the track to click or auditioner. |
|
|
the problem with this fix is that visual_time_axis.cc is not used by anyone anymore, so the real issue must be somewhere else. thanks for the suggestion, though. |
|
|
It's a general problem. You shouldn't be able to make buses share the same name. It seems you can make arbitrary number of buses with the same name. |
|
2009-04-28 00:41
|
1692.patch (1,744 bytes)
diff --git a/gtk2_ardour/route_time_axis.cc b/gtk2_ardour/route_time_axis.cc
index 2b622bd..df85cf6 100644
--- a/gtk2_ardour/route_time_axis.cc
+++ b/gtk2_ardour/route_time_axis.cc
@@ -1346,11 +1346,14 @@ RouteTimeAxisView::name_entry_changed ()
return;
}
- if (_session.route_name_unique (x)) {
- _route->set_name (x);
- } else {
+ if (!_session.route_name_unique (x)) {
ARDOUR_UI::instance()->popup_error (_("A track already exists with that name"));
name_entry.set_text (_route->name());
+ } else if (_session.route_name_internal (x)) {
+ ARDOUR_UI::instance()->popup_error (_("You cannot create a track with that name as it is reserved for Ardour"));
+ name_entry.set_text (_route->name());
+ } else {
+ _route->set_name (x);
}
}
diff --git a/libs/ardour/ardour/session.h b/libs/ardour/ardour/session.h
index c2e7e23..ce29928 100644
--- a/libs/ardour/ardour/session.h
+++ b/libs/ardour/ardour/session.h
@@ -332,6 +332,7 @@ class Session : public PBD::StatefulDestructible, public boost::noncopyable
boost::shared_ptr<Route> route_by_remote_id (uint32_t id);
bool route_name_unique (string) const;
+ bool route_name_internal (string) const;
bool get_record_enabled() const {
return (record_status () >= Enabled);
diff --git a/libs/ardour/session.cc b/libs/ardour/session.cc
index e2e38a1..fdb396d 100644
--- a/libs/ardour/session.cc
+++ b/libs/ardour/session.cc
@@ -4002,6 +4002,20 @@ Session::route_name_unique (string n) const
return true;
}
+bool
+Session::route_name_internal (string n) const
+{
+ if (auditioner && auditioner->name() == n) {
+ return true;
+ }
+
+ if (_click_io && _click_io->name() == n) {
+ return true;
+ }
+
+ return false;
+}
+
uint32_t
Session::n_playlists () const
{
|
|
|
3.0 already has code to stop you creating tracks with the same name. The attached patch extends this to stop "click" and "auditioner" being used as track names. |
|
|
Patch committed to 3.0. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-05-22 08:23 | SaBer | New Issue | |
| 2007-05-22 08:25 | SaBer | Note Added: 0004009 | |
| 2007-05-22 23:23 | SaBer | Note Added: 0004013 | |
| 2007-05-30 14:11 | paul | Note Added: 0004030 | |
| 2007-07-25 21:33 | b0ef | Note Added: 0004199 | |
| 2008-05-14 23:21 | paul | Relationship added | has duplicate 0002234 |
| 2009-04-28 00:41 | cth103 | File Added: 1692.patch | |
| 2009-04-28 00:42 | cth103 | Note Added: 0005923 | |
| 2009-04-29 16:16 | cth103 | cost | => 0.00 |
| 2009-04-29 16:16 | cth103 | Note Added: 0005943 | |
| 2009-04-29 16:16 | cth103 | Status | new => resolved |
| 2009-04-29 16:16 | cth103 | Fixed in Version | => SVN 3.0 |
| 2009-04-29 16:16 | cth103 | Resolution | open => fixed |
| 2009-04-29 16:16 | cth103 | Assigned To | => cth103 |
| 2020-04-19 20:12 | system | Note Added: 0021524 | |
| 2020-04-19 20:12 | system | Status | resolved => closed |