View Issue Details

IDProjectCategoryView StatusLast Update
0001684ardourfeaturespublic2008-11-21 00:00
Reportermschwarzenberg Assigned Topaul  
PrioritynormalSeverityfeatureReproducibilityalways
Status closedResolutionfixed 
Product Version2.0 
Summary0001684: crossfade editor: remove obsolete additional click for activating default fade shapes
DescriptionThis patch obsoletes the - for me annoying - additional click on the "Fade In" / "Fade Out" button when one iteratively tries to find the most appropriate preset
combination for both fades. With this patch all fade shape buttons are always active. The "Fade Out"/"Fade In" buttons and curves are selected accordingly when a shape button is clicked.
 
TagsNo tags attached.

Activities

2007-05-16 22:47

 

crossfade-quickchange.diff (1,499 bytes)   
Index: gtk2_ardour/crossfade_edit.cc
===================================================================
--- gtk2_ardour/crossfade_edit.cc	(revision 1845)
+++ gtk2_ardour/crossfade_edit.cc	(working copy)
@@ -721,6 +721,20 @@
 void
 CrossfadeEditor::apply_preset (Preset *preset)
 {
+  
+	WhichFade wf =  find(fade_in_presets->begin(), fade_in_presets->end(), preset) != fade_in_presets->end() ? In : Out;
+	
+	if (current != wf) {
+	  
+	      	if (wf == In) {
+			select_in_button.clicked();
+		} else {
+			select_out_button.clicked();
+		}
+		
+		curve_select_clicked (wf);
+	}  
+	
 	for (list<Point*>::iterator i = fade[current].points.begin(); i != fade[current].points.end(); ++i) {
 		delete *i;
 	}
@@ -962,14 +976,6 @@
 			(*i)->box->show ();
 		}
 
-		for (vector<Button*>::iterator i = fade_out_buttons.begin(); i != fade_out_buttons.end(); ++i) {
-			(*i)->set_sensitive (false);
-		}
-
-		for (vector<Button*>::iterator i = fade_in_buttons.begin(); i != fade_in_buttons.end(); ++i) {
-			(*i)->set_sensitive (true);
-		}
-
 	} else {
 
 		for (vector<ArdourCanvas::WaveView*>::iterator i = fade[In].waves.begin(); i != fade[In].waves.end(); ++i) {
@@ -993,14 +999,6 @@
 			(*i)->box->show();
 		}
 
-		for (vector<Button*>::iterator i = fade_out_buttons.begin(); i != fade_out_buttons.end(); ++i) {
-			(*i)->set_sensitive (true);
-		}
-
-		for (vector<Button*>::iterator i = fade_in_buttons.begin(); i != fade_in_buttons.end(); ++i) {
-			(*i)->set_sensitive (false);
-		}
-
 	}
 }
 
crossfade-quickchange.diff (1,499 bytes)   

paul

2007-05-30 14:56

administrator   ~0004032

patch applied and committed, along with your email suggestion for fixing the selection of both sets of points when the reset button is pressed.

thanks for the suggestions and fixes.

Issue History

Date Modified Username Field Change
2007-05-16 22:47 mschwarzenberg New Issue
2007-05-16 22:47 mschwarzenberg File Added: crossfade-quickchange.diff
2007-05-30 14:56 paul Status new => resolved
2007-05-30 14:56 paul Resolution open => fixed
2007-05-30 14:56 paul Assigned To => paul
2007-05-30 14:56 paul Note Added: 0004032
2008-11-21 00:00 seablade Status resolved => closed