View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001682 | ardour | bugs | public | 2007-05-16 22:28 | 2020-04-19 20:12 |
| Reporter | lincoln | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | random |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.0 | ||||
| Summary | 0001682: Playhead does not follow click on bar line | ||||
| Description | If you click on the bar line the playhead will not always jump to the point where you clicked. However pressing play starts from the desired position. I know one can press P to move the playhead but this I still regard this as a rough edge. This is on SVN latest 2.0 ongoing. | ||||
| Tags | No tags attached. | ||||
|
|
I can confirm this on 2.0.2. One session of mine behaves like this always. |
|
2007-05-21 20:33
|
|
|
|
Uploaded a session file that does this always for me (drums5.ardour). |
|
|
same here on some (bigger)sessions (with Ardour 2.0.2) edit: I experience this behaviour here on many sessions now regardless how big and if they are new or made with 0.99. I also had a case where the playcursor was invisible after it left the editor-window and "center session view at playhead" was ordered. (So it looks a bit as if this is not an issue with the click to position the playhead but with the visibility of the playhead in some cases...) |
|
2007-06-03 21:08
|
playhead_ruler.patch (646 bytes)
Index: gtk2_ardour/editor_rulers.cc
===================================================================
--- gtk2_ardour/editor_rulers.cc (revision 1946)
+++ gtk2_ardour/editor_rulers.cc (working copy)
@@ -156,9 +156,7 @@
if (session->is_auditioning()) {
session->cancel_audition ();
}
- /* transport playhead */
- snap_to (where);
- session->request_locate (where);
+
_dragging_playhead = true;
break;
@@ -202,7 +200,7 @@
/* transport playhead */
_dragging_playhead = false;
snap_to (where);
- session->request_locate (where);
+ session->request_locate (where, session->transport_rolling());
break;
case 2:
|
|
|
I attached a small patch that takes care of this bug. The playhead will always follow the position clicked on the ruler. After much playing around it came down to double triggering of events (ruler_button_press and ruler_button_release) I simply removed the locate handling logic from the button_press and left it in button_release. The behaviour is now similar to pressing P, works always and multiple presses with transport rolling will not end up stopping the transport. Somehow this bug really got to me! |
|
|
hi lincoln, i already tried the patch and it woks good here - the playhead will always take the position where i click in the bar-line. cheers, doc |
|
|
this patch is not quite correct, and also removes some desirable functionality. if the user wants to play immediately after a locate, they should activate autoplay. i don't see it as being a good thing that click on the rulers always starts the transport rolling, when "p" and other kinds of locates depend on the autoplay setting. there was also a specific reason for having "playhead locates on button press" rather than release - I am not sure what it was at the moment. I agree that the logic should not be duplicated, and will look into what to do about it. |
|
|
Paul, I don't understand. When clicking in the ruler when stopped and auto play is off, the transport will not start rolling. Infact with this patch clicking on the ruler behaves exactly like pressing p with both autoplay on and off. What is not nice without the patch is that clicking on the ruler will not move the playhead but when you start the transport it starts from the clicked position. The play head just jumps to the desired position on play. So basically there is an action with no visual feedback. |
|
|
i've applied a modified version of this patch to branches/2.0-ongoing. i'd appreciate confirmation that it still works as you intended, then we can mark this resolved/closed. |
|
|
Indeed it does. Thanks. |
|
|
see notes. fixed in branches/2.0-ongoing |
|
|
There is a visual oddity since this has been fixed. Occasionally when clicking on the ruler to locate the playhead, the playhead jumps to the new location, then jumps back to it's original location, then jumps back to the new location. If it happens, it happens when the mouse button is released. |
|
|
see notes. oofus - i think the behaviour you referred to is gone, and if not is not actually related to this bug or feature, but has more to do with playhead tracking in general. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-05-16 22:28 | lincoln | New Issue | |
| 2007-05-16 23:15 | SaBer | Note Added: 0003983 | |
| 2007-05-21 20:33 | SaBer | File Added: drums5.ardour | |
| 2007-05-21 20:35 | SaBer | Note Added: 0004006 | |
| 2007-05-21 22:12 | zettberlin | Note Added: 0004008 | |
| 2007-05-21 22:27 | zettberlin | Note Edited: 0004008 | |
| 2007-06-03 12:18 | zettberlin | Note Edited: 0004008 | |
| 2007-06-03 12:20 | zettberlin | Note Edited: 0004008 | |
| 2007-06-03 21:08 | lincoln | File Added: playhead_ruler.patch | |
| 2007-06-03 21:14 | lincoln | Note Added: 0004056 | |
| 2007-06-03 21:29 | lincoln | Note Edited: 0004056 | |
| 2007-06-03 21:30 | nowhiskey | Note Added: 0004057 | |
| 2007-08-24 12:36 | paul | Note Added: 0004288 | |
| 2007-08-24 20:46 | lincoln | Note Added: 0004292 | |
| 2007-08-27 13:00 | paul | Note Added: 0004302 | |
| 2007-08-27 14:07 | lincoln | Note Added: 0004306 | |
| 2007-08-27 15:32 | paul | Status | new => resolved |
| 2007-08-27 15:32 | paul | Resolution | open => fixed |
| 2007-08-27 15:32 | paul | Assigned To | => paul |
| 2007-08-27 15:32 | paul | Note Added: 0004308 | |
| 2007-08-27 21:29 | oofus | Status | resolved => feedback |
| 2007-08-27 21:29 | oofus | Resolution | fixed => reopened |
| 2007-08-27 21:29 | oofus | Note Added: 0004312 | |
| 2008-11-26 21:40 | paul | cost | => 0.00 |
| 2008-11-26 21:40 | paul | Status | feedback => resolved |
| 2008-11-26 21:40 | paul | Resolution | reopened => fixed |
| 2008-11-26 21:40 | paul | Note Added: 0005383 | |
| 2020-04-19 20:12 | system | Note Added: 0021522 | |
| 2020-04-19 20:12 | system | Status | resolved => closed |
