View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001669 | ardour | bugs | public | 2007-05-13 01:15 | 2008-11-21 00:00 |
| Reporter | Endolith | Assigned To | timbyr | ||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.0 | ||||
| Summary | 0001669: Context-clicking main clock gives pointless "Mode" option | ||||
| Description | To change clock modes you: 1. Context-click the clock 2. Press the "Mode" option 3. Select the mode you want You should instead: 1. Context-click the clock 2. Select the mode you want | ||||
| Tags | No tags attached. | ||||
|
|
I agree, I'll attach a patch that should do what you suggest. I'm also thinking that there shouldn't be an "Off" mode as it can be hard to get the clock back from that mode because of the width of it. I think a better alternative would be use a check menu item(possibly in the view menu) to completely hide a clock. |
|
2007-05-13 02:32
|
move_clock_modes_into_toplevel_popup_menu.patch (1,581 bytes)
Index: gtk2_ardour/audio_clock.cc
===================================================================
--- gtk2_ardour/audio_clock.cc (revision 1837)
+++ gtk2_ardour/audio_clock.cc (working copy)
@@ -1793,18 +1793,12 @@
ops_menu = new Menu;
MenuList& ops_items = ops_menu->items();
ops_menu->set_name ("ArdourContextMenu");
-
- Menu *mode_menu = manage (new Menu);
- MenuList& mode_items = mode_menu->items();
- mode_menu->set_name ("ArdourContextMenu");
- mode_items.push_back (MenuElem (_("Timecode"), bind (mem_fun(*this, &AudioClock::set_mode), SMPTE)));
- mode_items.push_back (MenuElem (_("Bars:Beats"), bind (mem_fun(*this, &AudioClock::set_mode), BBT)));
- mode_items.push_back (MenuElem (_("Minutes:Seconds"), bind (mem_fun(*this, &AudioClock::set_mode), MinSec)));
- mode_items.push_back (MenuElem (_("Audio Frames"), bind (mem_fun(*this, &AudioClock::set_mode), Frames)));
- mode_items.push_back (MenuElem (_("Off"), bind (mem_fun(*this, &AudioClock::set_mode), Off)));
-
- ops_items.push_back (MenuElem (_("Mode"), *mode_menu));
+ ops_items.push_back (MenuElem (_("Timecode"), bind (mem_fun(*this, &AudioClock::set_mode), SMPTE)));
+ ops_items.push_back (MenuElem (_("Bars:Beats"), bind (mem_fun(*this, &AudioClock::set_mode), BBT)));
+ ops_items.push_back (MenuElem (_("Minutes:Seconds"), bind (mem_fun(*this, &AudioClock::set_mode), MinSec)));
+ ops_items.push_back (MenuElem (_("Audio Frames"), bind (mem_fun(*this, &AudioClock::set_mode), Frames)));
+ ops_items.push_back (MenuElem (_("Off"), bind (mem_fun(*this, &AudioClock::set_mode), Off)));
}
void
|
|
|
requesting feedback on the patch and the idea to remove the "Off" mode from the clock modes(although that would depend on implementing alternate functionality) |
|
|
"I'm also thinking that there shouldn't be an "Off" mode as it can be hard to get the clock back from that mode because of the width of it." Good point. It doesn't even look like something clickable. :-) I also noticed that changing the tempo from a three-digit number to a two-digit number partway through a song results in the clock changing widths and all the buttons shifting along with it. Not really a problem, but kind of weird to happen during playback. Maybe the width of the clocks should be set by considering the entire song and calculating the widest it will ever need to be? "I think a better alternative would be use a check menu item(possibly in the view menu) to completely hide a clock." Good idea. |
|
|
the patch works good, but about the "off" mode - except removing .ardour2 folder, i did not found out yet, how i get the clock back, once switched off. |
|
|
patch applied to 2.0-ongoing |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-05-13 01:15 | Endolith | New Issue | |
| 2007-05-13 02:32 | timbyr | Note Added: 0003957 | |
| 2007-05-13 02:32 | timbyr | File Added: move_clock_modes_into_toplevel_popup_menu.patch | |
| 2007-05-13 02:32 | timbyr | Status | new => assigned |
| 2007-05-13 02:32 | timbyr | Assigned To | => timbyr |
| 2007-05-13 02:35 | timbyr | Note Added: 0003958 | |
| 2007-05-13 02:35 | timbyr | Status | assigned => feedback |
| 2007-05-13 02:53 | Endolith | Note Added: 0003959 | |
| 2007-05-13 02:55 | Endolith | Note Edited: 0003959 | |
| 2007-05-13 06:32 | timbyr | Relationship added | related to 0001483 |
| 2007-05-14 10:22 | nowhiskey | Note Added: 0003966 | |
| 2007-05-21 14:15 | paul | Status | feedback => resolved |
| 2007-05-21 14:15 | paul | Resolution | open => fixed |
| 2007-05-21 14:15 | paul | Note Added: 0004005 | |
| 2007-07-18 03:33 | timbyr | Relationship deleted | related to 0001483 |
| 2008-11-21 00:00 | seablade | Status | resolved => closed |
