View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001645 | ardour | bugs | public | 2007-05-04 21:14 | 2020-04-19 20:12 |
| Reporter | phadsge | Assigned To | cth103 | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.0 | ||||
| Summary | 0001645: useless/disfunctional hide-button on master/monitor-bus | ||||
| Description | the "hide"-button on master/monitor-bus is either useless (to be displayed) or not working (hiding the bus) correctly. | ||||
| Tags | No tags attached. | ||||
|
|
Confirmed; the master buss hide button in the mixer doesn't do anything, although it works in the editor. |
|
|
for me this looks more subtile. in the editor, if i click 'hide' master bus, shift+e funktion will be proceeded - have a look at the right side in the 'tracks/busses' master is still checked. in the mixer, if i click the hide button on master bus, it will become unchecked at the left side (strip/show), but i am not able to check again.(neither clicking on the hide button, nor clicking in the master check box (show) at the left. anyway, it does not really makes the workflow worse, but me too think that there is something running wrong here. cheers, doc |
|
|
This should be fixed in trunk; master or control routes no longer get a hide button in the mixer. Perhaps you could take a look and confirm? Thanks, Carl |
|
|
hallo carl, unfortunately i am running with jackd-0.103.0 here, so i do not have a working copy of the trunk... would be good if there is a patch for ongoing available. cheers, doc |
|
2007-11-04 17:32
|
2.0.patch (897 bytes)
diff -r -u -X exclude ardour.org/branches/2.0-ongoing/gtk2_ardour/mixer_strip.cc branches/2.0-ongoing/gtk2_ardour/mixer_strip.cc
--- ardour.org/branches/2.0-ongoing/gtk2_ardour/mixer_strip.cc 2007-11-04 17:16:46.000000000 +0000
+++ branches/2.0-ongoing/gtk2_ardour/mixer_strip.cc 2007-11-04 17:30:27.000000000 +0000
@@ -243,7 +243,13 @@
width_hide_box.pack_start (width_button, false, true);
width_hide_box.pack_start (top_event_box, true, true);
- width_hide_box.pack_end (hide_button, false, true);
+
+ if (!in_mixer || (!_route->master() && !_route->control())) {
+ /* we don't allow master or control routes to be hidden, unless
+ we're the editor mix strip */
+ width_hide_box.pack_end (hide_button, false, true);
+ }
+
Gtk::Alignment *gain_meter_alignment = Gtk::manage(new Gtk::Alignment());
gain_meter_alignment->set_padding(0, 4, 0, 0);
gain_meter_alignment->add(gpm);
|
|
|
Hi Doc, I've attached a patch against 2.0-ongoing, perhaps you could give it a try and give me your thoughts! Cheers, Carl |
|
|
hallo carl, well the patch is applying, but i am used to use -p1 or -p0 and the patch will be applied, but in this case i was asked like 'file to patch' ok, that was easy to copy+paste 'gtk2_ardour/mixer_strip.cc' and the patch got applied. now --editor-window: works great, no hide button, but unchecking at the right side 'tracks/busses' the master disappears and i am able to check it again! --mixer-window: no hide button at the strip, but on the left side, 'strips / show' i am not able to uncheck the master strip. it is always checked and clicking on it does not make anything. cheers and thanks for the patch, doc |
|
|
Thanks doc, the code has changed a bit between 2.0-ongoing and trunk, so if it's ok with you and since it's not a particularly serious bug I'll leave the fix for trunk only. Perhaps you could report back on this bug when you start using trunk? Thanks for your time! Carl |
|
|
Fixed in 3.0 SVN. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-05-04 21:14 | phadsge | New Issue | |
| 2007-05-11 15:21 | cth103 | Note Added: 0003940 | |
| 2007-05-11 15:21 | cth103 | Status | new => confirmed |
| 2007-05-11 15:37 | nowhiskey | Note Added: 0003943 | |
| 2007-11-04 16:42 | cth103 | Note Added: 0004521 | |
| 2007-11-04 16:42 | cth103 | Status | confirmed => feedback |
| 2007-11-04 17:09 | nowhiskey | Note Added: 0004522 | |
| 2007-11-04 17:32 | cth103 | File Added: 2.0.patch | |
| 2007-11-04 17:33 | cth103 | Note Added: 0004523 | |
| 2007-11-04 18:26 | nowhiskey | Note Added: 0004524 | |
| 2007-11-04 21:50 | cth103 | Note Added: 0004527 | |
| 2009-06-29 01:20 | cth103 | cost | => 0.00 |
| 2009-06-29 01:20 | cth103 | Note Added: 0006195 | |
| 2009-06-29 01:20 | cth103 | Status | feedback => resolved |
| 2009-06-29 01:20 | cth103 | Resolution | open => fixed |
| 2009-06-29 01:20 | cth103 | Assigned To | => cth103 |
| 2020-04-19 20:12 | system | Note Added: 0021518 | |
| 2020-04-19 20:12 | system | Status | resolved => closed |
