View Issue Details

IDProjectCategoryView StatusLast Update
0001628ardourfeaturespublic2008-11-21 00:02
ReporterJoeboy Assigned Topaul  
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Summary0001628: Only ask if ardour's being built with VST support for personal use once
DescriptionIt's kinda annoying having to answer the question about distributing answer every time you build it. More than once I've started it building, come back sometime later and found it's stopped on that question. Attached patch should cache the setting to a hidden file.

Version is current svn - doesn't appear to be an option in mantis though, and nor are either of the RCs (?).

Cheers
TagsNo tags attached.

Activities

2007-04-24 08:24

 

ardour_cache_personal_use_only_setting.patch (1,604 bytes)   
Index: SConstruct
===================================================================
--- SConstruct	(revision 1740)
+++ SConstruct	(working copy)
@@ -382,14 +382,22 @@
 #
 
 if env['VST']:
-    sys.stdout.write ("Are you building Ardour for personal use (rather than distribution to others)? [no]: ")
-    answer = sys.stdin.readline ()
-    answer = answer.rstrip().strip()
-    if answer != "yes" and answer != "y":
-        print 'You cannot build Ardour with VST support for distribution to others.\nIt is a violation of several different licenses. Build with VST=false.'
-        sys.exit (-1);
+    if os.path.isfile('.personal_use_only'):
+        print "Enabling VST support. Note that distributing a VST-enabled ardour\nis a violation of several different licences.\nBuild with VST=false if you intend to distribute ardour to others."
     else:
-        print "OK, VST support will be enabled"
+        sys.stdout.write ("Are you building Ardour for personal use (rather than distribution to others)? [no]: ")
+        answer = sys.stdin.readline ()
+        answer = answer.rstrip().strip()
+        if answer == "yes" or answer == "y":
+            fh = open('.personal_use_only', 'w')
+            fh.close()
+            print "OK, VST support will be enabled"
+        else:
+            print 'You cannot build Ardour with VST support for distribution to others.\nIt is a violation of several different licenses. Build with VST=false.'
+            sys.exit (-1);
+else:
+    if os.path.isfile('.personal_use_only'):
+        os.remove('.personal_use_only')
 
 
 #######################

paul

2007-04-26 01:06

administrator   ~0003840

applied and committed. nice work, thanks. i told you it wouldn't be hard, right? :)

Issue History

Date Modified Username Field Change
2007-04-24 08:24 Joeboy New Issue
2007-04-24 08:24 Joeboy File Added: ardour_cache_personal_use_only_setting.patch
2007-04-26 01:06 paul Status new => resolved
2007-04-26 01:06 paul Resolution open => fixed
2007-04-26 01:06 paul Assigned To => paul
2007-04-26 01:06 paul Note Added: 0003840
2008-11-21 00:02 seablade Status resolved => closed