View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001622 | ardour | features | public | 2007-04-21 10:12 | 2007-07-04 11:38 |
| Reporter | oofus | Assigned To | timbyr | ||
| Priority | normal | Severity | feature | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Platform | Dual 666MHz PIII | OS | Mandriva | OS Version | 2007 |
| Summary | 0001622: Option to use the file name as the track name when importing audio files. | ||||
| Description | Option to use the file name as the track name when importing audio files. | ||||
| Tags | No tags attached. | ||||
|
2007-05-12 07:21
|
use_file_name_as_track_name_on_import.patch (799 bytes)
Index: gtk2_ardour/editor_audio_import.cc
===================================================================
--- gtk2_ardour/editor_audio_import.cc (revision 1833)
+++ gtk2_ardour/editor_audio_import.cc (working copy)
@@ -477,6 +477,7 @@
if (!at.empty()) {
boost::shared_ptr<AudioRegion> copy (boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (region)));
at.front()->diskstream()->playlist()->add_region (copy, pos);
+ at.front()->set_name(copy->name(), this);
}
break;
}
@@ -487,6 +488,7 @@
if (!at.empty()) {
boost::shared_ptr<AudioRegion> copy (boost::dynamic_pointer_cast<AudioRegion> (RegionFactory::create (region)));
at.front()->diskstream()->playlist()->add_region (copy, pos);
+ at.front()->set_name(copy->name(), this);
}
break;
}
|
|
|
I've attached a patch that gives the track the same name as the file/region being imported when importing "as Track" or "as Tape Track". I don't see any point in it being optional. |
|
|
request for feedback |
|
|
this actually looks like a very nice feature, but if i import files named like: tm-2007-04-03T01:59:08.wav i get a warning: [WARNING]: you cannot use colons to name objects with I/O connections another thing is that the name of course does not fit into the track-name-space. but perhaps i will never want to have a track named like that, so i can import this file in a different way and keep this function for importing files with more reasonable names, which i want to have as a track name. so, my thoughts, for handling this function, we need another menu item, sth like 'import keeping the name'. cheers, doc |
|
|
I think a simpler solution is to have a tick box in the import dialogue, that is ticked by default, called 'Use file name as track name' (or maybe something shorter !). Then it can be un-ticked when you don't want the track to be named after the file. It could sit down the bottom next to 'split channels' |
|
|
that is a good idea, but the checkbox should be accessible only if in the down-right corner the option 'add as a new track' or 'add as a new tape track' is chosen. |
|
|
Yes, grey it out for other options |
|
|
Some characters are not allowed in Track names which is why you get the warning. "another thing is that the name of course does not fit into the track-name-space." That is a more general problem that also applies when manually entering a track name. As I said before I don't see there being any point in not giving the track the same name as the file when importing "as Track". If there is no option then: 1. The track is given the same name as the file but the user would like a different name and changes the name manually. 2. The track is given the same name as the file and the user finds the name acceptable. It it was an option then the track either gets a default name(as it does now) or the name of the file. In either case the user needs to change the name manually if they are not happy with the name. |
|
|
An equivalent patch has been applied to the trunk branch as of svn rev 2076. |
|
|
all working fine |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-04-21 10:12 | oofus | New Issue | |
| 2007-05-12 07:21 | timbyr | File Added: use_file_name_as_track_name_on_import.patch | |
| 2007-05-12 07:26 | timbyr | Note Added: 0003945 | |
| 2007-05-12 07:26 | timbyr | Status | new => assigned |
| 2007-05-12 07:26 | timbyr | Assigned To | => timbyr |
| 2007-05-12 07:27 | timbyr | Note Added: 0003946 | |
| 2007-05-12 07:27 | timbyr | Status | assigned => feedback |
| 2007-05-12 07:28 | timbyr | Relationship added | related to 0001483 |
| 2007-05-12 13:24 | nowhiskey | Note Added: 0003950 | |
| 2007-05-12 13:31 | oofus | Note Added: 0003951 | |
| 2007-05-12 14:34 | nowhiskey | Note Added: 0003952 | |
| 2007-05-12 14:48 | oofus | Note Added: 0003953 | |
| 2007-05-13 01:13 | timbyr | Note Added: 0003956 | |
| 2007-06-28 13:07 | timbyr | Status | feedback => resolved |
| 2007-06-28 13:07 | timbyr | Resolution | open => fixed |
| 2007-06-28 13:07 | timbyr | Note Added: 0004087 | |
| 2007-07-04 11:38 | oofus | Status | resolved => closed |
| 2007-07-04 11:38 | oofus | Note Added: 0004096 | |
| 2007-07-18 03:37 | timbyr | Relationship deleted | related to 0001483 |
