View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001577 | ardour | bugs | public | 2007-03-25 12:35 | 2008-11-21 00:09 |
| Reporter | esaracco | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0001577: Region copying problem | ||||
| Description | [Last SVN trunk] Right clicking on a region and choosing "Edition/Copy", automatically move the region to the beginning of the track. | ||||
| Tags | No tags attached. | ||||
|
|
Confirmed. |
|
2007-04-06 18:39
|
1577.patch (1,051 bytes)
Index: gtk2_ardour/editor_ops.cc
===================================================================
--- gtk2_ardour/editor_ops.cc (revision 164)
+++ gtk2_ardour/editor_ops.cc (working copy)
@@ -2730,6 +2730,10 @@
PlaylistMapping (TimeAxisView* tvp) : tv (tvp) {}
};
+
+/** Cut, copy or clear the selected regions.
+ * @param op Operation (Cut, Copy or Clear)
+ */
void
Editor::cut_copy_regions (CutCopyOp op)
{
@@ -2819,7 +2823,7 @@
boost::shared_ptr<AudioRegion> ar = boost::dynamic_pointer_cast<AudioRegion>((*x)->region());
boost::shared_ptr<Region> _xx;
-
+
switch (op) {
case Cut:
if (!ar) break;
@@ -2831,8 +2835,11 @@
case Copy:
if (!ar) break;
-
- npl->add_region ((*x)->region(), (*x)->region()->position() - first_position);
+
+ /* make a copy of the region, otherwise the original one will
+ get moved when it is added to npl */
+ _xx = RegionFactory::create ((*x)->region());
+ npl->add_region (_xx, (*x)->region()->position() - first_position);
break;
case Clear:
|
|
|
The attached patch fixes it for me, but will need to check with Paul that the fix is sensible. |
|
|
modified version of carl's patch applied to my code. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-03-25 12:35 | esaracco | New Issue | |
| 2007-03-26 15:39 | cth103 | Note Added: 0003666 | |
| 2007-04-06 18:39 | cth103 | File Added: 1577.patch | |
| 2007-04-06 18:41 | cth103 | Note Added: 0003725 | |
| 2007-04-06 18:41 | cth103 | Status | new => feedback |
| 2007-04-06 22:47 | paul | Status | feedback => resolved |
| 2007-04-06 22:47 | paul | Resolution | open => fixed |
| 2007-04-06 22:47 | paul | Assigned To | => paul |
| 2007-04-06 22:47 | paul | Note Added: 0003737 | |
| 2008-11-21 00:09 | seablade | Status | resolved => closed |