View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001554ardourfeaturespublic2007-03-14 13:472008-11-21 00:30
Reporterspanky Assigned Tocth103  
PrioritynormalSeverityfeatureReproducibilityalways
Status closedResolutionfixed 
Summary0001554: Shuttle control should remember playback state
DescriptionWhen I use the Shuttle speed control with the mouse while playing, the playback stops on mouse button release. Could you add an option to have the playback state remembered, so the playback will continue after releasing the Shuttle control?
TagsNo tags attached.

Activities

spanky

2007-03-14 13:51

reporter   ~0003577

Oops, sorry: there is already the Auto Play feature. Please delete this issue!

cth103

2007-03-15 00:35

administrator   ~0003579

Reporter has found that this feature already exists!

spanky

2007-03-31 20:29

reporter   ~0003692

Reopening: was a bug, not a feature - and fix included:

--- gtk2_ardour/ardour_ui2.cc 2007-03-31 22:00:33.000000000 +0200
+++ gtk2_ardour/ardour_ui2.cc 2007-03-31 22:05:27.000000000 +0200
@@ -603,7 +603,7 @@
         shuttle_grabbed = false;
         shuttle_box.remove_modal_grab ();
         if (Config->get_shuttle_behaviour() == Sprung) {
- if (Config->get_auto_play() || roll_button.get_state()) {
+ if (Config->get_auto_play() || session->transport_rolling()) {
                 shuttle_fract = SHUTTLE_FRACT_SPEED1;
                 session->request_transport_speed (1.0);
                 stop_button.set_visual_state (0);

spanky

2007-04-09 14:44

reporter   ~0003772

could somebody check this, too? thanks!

2007-04-10 13:42

 

shuttle.patch (588 bytes)    
Index: gtk2_ardour/ardour_ui2.cc
===================================================================
--- gtk2_ardour/ardour_ui2.cc	(revision 176)
+++ gtk2_ardour/ardour_ui2.cc	(working copy)
@@ -606,7 +606,7 @@
 		shuttle_grabbed = false;
 		shuttle_box.remove_modal_grab ();
 		if (Config->get_shuttle_behaviour() == Sprung) {
-			if (Config->get_auto_play() || roll_button.get_state()) {
+			if (Config->get_auto_play() || session->transport_rolling()) {
 				shuttle_fract = SHUTTLE_FRACT_SPEED1;				
 				session->request_transport_speed (1.0);
 				stop_button.set_visual_state (0);
shuttle.patch (588 bytes)   

cth103

2007-04-10 13:43

administrator   ~0003780

Confirmed here, and the patch works for me too. I've attached an updated version of the patch which applies to current SVN.

paul

2007-04-10 14:12

administrator   ~0003782

carl's patch applied to my source code.

spanky

2007-04-10 17:04

reporter   ~0003787

Sorry, but I need to reopen again. The previous patch didn't work when using the shuttle control and transport was stopped. Another fix included again:

--- ardour_ui2.cc (Revision 1694)
+++ ardour_ui2.cc (Arbeitskopie)
@@ -606,7 +606,7 @@
         shuttle_grabbed = false;
         shuttle_box.remove_modal_grab ();
         if (Config->get_shuttle_behaviour() == Sprung) {
- if (Config->get_auto_play() || session->transport_rolling()) {
+ if (Config->get_auto_play() || roll_button.get_visual_state()) {
                 shuttle_fract = SHUTTLE_FRACT_SPEED1;
                 session->request_transport_speed (1.0);
                 stop_button.set_visual_state (0);

cth103

2007-04-10 18:00

administrator   ~0003788

Well spotted and thanks, I have committed this updated patch. Hopefully that should sort it, feel free to re-open if not!
Carl

Issue History

Date Modified Username Field Change
2007-03-14 13:47 spanky New Issue
2007-03-14 13:51 spanky Note Added: 0003577
2007-03-15 00:35 cth103 Status new => resolved
2007-03-15 00:35 cth103 Resolution open => no change required
2007-03-15 00:35 cth103 Assigned To => cth103
2007-03-15 00:35 cth103 Note Added: 0003579
2007-03-31 20:29 spanky Status resolved => feedback
2007-03-31 20:29 spanky Resolution no change required => reopened
2007-03-31 20:29 spanky Note Added: 0003692
2007-04-09 14:44 spanky Note Added: 0003772
2007-04-10 13:42 cth103 File Added: shuttle.patch
2007-04-10 13:43 cth103 Note Added: 0003780
2007-04-10 14:12 paul Status feedback => resolved
2007-04-10 14:12 paul Resolution reopened => fixed
2007-04-10 14:12 paul Note Added: 0003782
2007-04-10 17:04 spanky Status resolved => feedback
2007-04-10 17:04 spanky Resolution fixed => reopened
2007-04-10 17:04 spanky Note Added: 0003787
2007-04-10 18:00 cth103 Status feedback => resolved
2007-04-10 18:00 cth103 Resolution reopened => fixed
2007-04-10 18:00 cth103 Note Added: 0003788
2008-11-21 00:30 seablade Status resolved => closed