View Issue Details

IDProjectCategoryView StatusLast Update
0001545ardourbugspublic2008-11-21 00:09
ReporterMrBouncy Assigned Topaul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0001545: cannot preserve playlists when cleaning up unused sources
DescriptionFrom the editor window 'cleanup unused sources' dialog, if inactive playlists should stay, the first attempt to use the 'Keep playlist' option cancels further operation.

browsing through the code shows that this button returns RESPONSE_CANCEL when it should be using RESPONSE_REJECT.
Additional Informationthe attached diff file seems to fix the errant behavior on my system, I was able to preserve multiple playlists and got the summary report at the end.

a subsequent call to 'flush wastebasket' did not find any files to remove though they were properly relocated to a dead_sounds directory.
TagsNo tags attached.

Activities

2007-03-10 22:21

 

ardour-2.0b11.1_playlists.diff (430 bytes)   
--- gtk2_ardour/editor.cc.orig	2007-01-17 12:04:46.000000000 -0800
+++ gtk2_ardour/editor.cc	2007-03-10 13:49:54.273007000 -0800
@@ -3905,7 +3905,7 @@
 	label.show ();
 
 	dialog.add_button (_("Delete playlist"), RESPONSE_ACCEPT);
-	dialog.add_button (_("Keep playlist"), RESPONSE_CANCEL);
+	dialog.add_button (_("Keep playlist"), RESPONSE_REJECT);
 	dialog.add_button (_("Cancel"), RESPONSE_CANCEL);
 
 	switch (dialog.run ()) {

paul

2007-03-15 20:42

administrator   ~0003582

committed. thanks!

Issue History

Date Modified Username Field Change
2007-03-10 22:21 MrBouncy New Issue
2007-03-10 22:21 MrBouncy File Added: ardour-2.0b11.1_playlists.diff
2007-03-15 20:42 paul Status new => resolved
2007-03-15 20:42 paul Resolution open => fixed
2007-03-15 20:42 paul Assigned To => paul
2007-03-15 20:42 paul Note Added: 0003582
2008-11-21 00:09 seablade Status resolved => closed