View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001541 | ardour | bugs | public | 2007-03-08 01:48 | 2008-11-21 00:09 |
| Reporter | spanky | Assigned To | cth103 | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0001541: Level meter peak textfield selection / drag problem | ||||
| Description | You can click on the textfield above the level meter of a track to reset its peak information. After clicking, it seems that there will be started a mouse drag. Moving the mouse cursor selects the text in the textfield (the selected characters become green) and clicking again and then leaving the textfield can lead to a drag&drop-action in gnome, blocking the mouse curson until you finish the drag wit another click or ESC. Maybe you should make the textfield non-editable or non-selectable. | ||||
| Tags | No tags attached. | ||||
|
2007-03-08 11:19
|
peak-display (2,139 bytes)
Index: gtk2_ardour/gain_meter.cc
===================================================================
--- gtk2_ardour/gain_meter.cc (revision 1560)
+++ gtk2_ardour/gain_meter.cc (working copy)
@@ -105,11 +105,11 @@
gain_display_box.pack_start (gain_display, true, true);
peak_display.set_name ("MixerStripPeakDisplay");
- peak_display.set_has_frame (false);
- peak_display.set_editable (false);
+// peak_display.set_has_frame (false);
+// peak_display.set_editable (false);
set_size_request_to_display_given_text (peak_display, "-80.g", 2, 6); /* note the descender */
max_peak = minus_infinity();
- peak_display.set_text (_("-inf"));
+ peak_display.set_label (_("-inf"));
peak_display.unset_flags (Gtk::CAN_FOCUS);
meter_metric_area.set_name ("MeterMetricsStrip");
@@ -327,10 +327,10 @@
max_peak = mpeak;
/* set peak display */
if (max_peak <= -200.0f) {
- peak_display.set_text (_("-inf"));
+ peak_display.set_label (_("-inf"));
} else {
snprintf (buf, sizeof(buf), "%.1f", max_peak);
- peak_display.set_text (buf);
+ peak_display.set_label (buf);
}
if (max_peak >= 0.0f) {
@@ -494,7 +494,7 @@
}
max_peak = -INFINITY;
- peak_display.set_text (_("-Inf"));
+ peak_display.set_label (_("-Inf"));
peak_display.set_name ("MixerStripPeakDisplay");
}
@@ -516,7 +516,7 @@
case 1:
meters[which].meter->clear();
max_peak = minus_infinity();
- peak_display.set_text (_("-inf"));
+ peak_display.set_label (_("-inf"));
peak_display.set_name ("MixerStripPeakDisplay");
break;
Index: gtk2_ardour/gain_meter.h
===================================================================
--- gtk2_ardour/gain_meter.h (revision 1560)
+++ gtk2_ardour/gain_meter.h (working copy)
@@ -86,7 +86,7 @@
Gtkmm2ext::VSliderController *gain_slider;
Gtk::Adjustment gain_adjustment;
Gtkmm2ext::FocusEntry gain_display;
- Gtk::Entry peak_display;
+ Gtk::Button peak_display;
Gtk::HBox gain_display_box;
Gtk::HBox fader_box;
Gtk::DrawingArea meter_metric_area;
|
|
|
Hi, Thanks for the report. The attached patch should fix the problem. Would you like to give it a try and see if it helps? Carl |
|
|
Hi Carl, this works great for me. Thanks! Sebastian |
|
|
Great, thanks for checking it out. |
|
|
applied to my source tree, will be in my next commit. keep them coming carl ! :) |
|
|
Patch applied to SVN by Paul. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-03-08 01:48 | spanky | New Issue | |
| 2007-03-08 11:19 | cth103 | File Added: peak-display | |
| 2007-03-08 11:20 | cth103 | Status | new => assigned |
| 2007-03-08 11:20 | cth103 | Assigned To | => cth103 |
| 2007-03-08 11:21 | cth103 | Note Added: 0003531 | |
| 2007-03-08 11:21 | cth103 | Status | assigned => feedback |
| 2007-03-08 12:48 | spanky | Note Added: 0003533 | |
| 2007-03-08 13:04 | cth103 | Note Added: 0003534 | |
| 2007-03-08 13:04 | cth103 | Status | feedback => confirmed |
| 2007-03-08 13:43 | cth103 | Assigned To | cth103 => |
| 2007-03-09 02:06 | paul | Note Added: 0003540 | |
| 2007-03-12 16:20 | cth103 | Status | confirmed => resolved |
| 2007-03-12 16:20 | cth103 | Resolution | open => fixed |
| 2007-03-12 16:20 | cth103 | Assigned To | => cth103 |
| 2007-03-12 16:20 | cth103 | Note Added: 0003561 | |
| 2008-11-21 00:09 | seablade | Status | resolved => closed |
