View Issue Details

IDProjectCategoryView StatusLast Update
0001539ardourbugspublic2008-11-21 00:09
Reporterspanky Assigned Tocth103  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0001539: Track active state is not saved properly
DescriptionMark a track as inactive and save the session. After loading the session the track is active again, but the option "active" is unchecked. You have to activate and deactivate the track again in order to change its status to inactive.
TagsNo tags attached.

Activities

2007-03-08 11:43

 

track-enable (1,853 bytes)   
Index: gtk2_ardour/audio_time_axis.cc
===================================================================
--- gtk2_ardour/audio_time_axis.cc	(revision 1560)
+++ gtk2_ardour/audio_time_axis.cc	(working copy)
@@ -107,21 +107,13 @@
 	
 	_route->panner().Changed.connect (mem_fun(*this, &AudioTimeAxisView::update_pans));
 
+	update_control_names ();
+
 	if (is_audio_track()) {
 
-		controls_ebox.set_name ("AudioTrackControlsBaseUnselected");
-		controls_base_selected_name = "AudioTrackControlsBaseSelected";
-		controls_base_unselected_name = "AudioTrackControlsBaseUnselected";
-
 		/* ask for notifications of any new RegionViews */
 		_view->RegionViewAdded.connect (mem_fun(*this, &AudioTimeAxisView::region_view_added));
 		_view->attach ();
-
-	} else { /* bus */
-
-		controls_ebox.set_name ("AudioBusControlsBaseUnselected");
-		controls_base_selected_name = "AudioBusControlsBaseSelected";
-		controls_base_unselected_name = "AudioBusControlsBaseUnselected";
 	}
 
 	post_construct ();
@@ -621,7 +613,19 @@
 AudioTimeAxisView::route_active_changed ()
 {
 	RouteTimeAxisView::route_active_changed ();
+	update_control_names ();
+}
 
+
+/**
+ *    Set up the names of the controls so that they are coloured
+ *    correctly depending on whether this route is inactive or
+ *    selected.
+ */
+
+void
+AudioTimeAxisView::update_control_names ()
+{
 	if (is_audio_track()) {
 		if (_route->active()) {
 			controls_ebox.set_name ("AudioTrackControlsBaseUnselected");
Index: gtk2_ardour/audio_time_axis.h
===================================================================
--- gtk2_ardour/audio_time_axis.h	(revision 1560)
+++ gtk2_ardour/audio_time_axis.h	(working copy)
@@ -114,6 +114,7 @@
 	void pan_hidden ();
 
 	void update_pans ();
+	void update_control_names ();
 
 	AutomationTimeAxisView* gain_track;
 	AutomationTimeAxisView* pan_track;
track-enable (1,853 bytes)   

cth103

2007-03-08 11:44

administrator   ~0003532

Hi,

Thanks for the report. The attached patch should fix the problem; I believe the track state is getting saved correctly but just not quite restored properly when the session is re-loaded. Would you like to try the patch and tell me how you get on?

Carl

spanky

2007-03-08 13:12

reporter   ~0003535

Hi Carl,

you're right: after applying the patch the session loaded correctly with the previously saved track states. saving and loading the session again also works without any problems now. thank you for the quick support!

Sebastian

paul

2007-03-08 23:21

administrator   ~0003538

patch applied to my source tree. it will be in my next commit.

cth103

2007-03-12 16:24

administrator   ~0003562

Patch applied to SVN by Paul.

Issue History

Date Modified Username Field Change
2007-03-08 01:14 spanky New Issue
2007-03-08 11:43 cth103 File Added: track-enable
2007-03-08 11:43 cth103 Status new => assigned
2007-03-08 11:43 cth103 Assigned To => cth103
2007-03-08 11:44 cth103 Note Added: 0003532
2007-03-08 11:44 cth103 Status assigned => feedback
2007-03-08 13:12 spanky Note Added: 0003535
2007-03-08 13:44 cth103 Status feedback => confirmed
2007-03-08 13:44 cth103 Assigned To cth103 =>
2007-03-08 23:21 paul Note Added: 0003538
2007-03-12 16:24 cth103 Status confirmed => resolved
2007-03-12 16:24 cth103 Resolution open => fixed
2007-03-12 16:24 cth103 Assigned To => cth103
2007-03-12 16:24 cth103 Note Added: 0003562
2008-11-21 00:09 seablade Status resolved => closed