View Issue Details

IDProjectCategoryView StatusLast Update
0001528ardourbugspublic2020-04-19 20:12
Reporterkjetil Assigned Topaul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0001528: Trying to activate/deactivate fade in/fade out doesn't work in automation mode
DescriptionUnless its the active object you are working on.

If its not, either nothing happens, or you enable/disable fade in/out in a different sound object than the one you are pointing to.

TagsNo tags attached.

Activities

cth103

2007-03-04 23:20

administrator   ~0003498

I think this is because when you click e.g. "activate" on the fade menu, the selected regions have their fades changed. When you're in the object mode, the right click that opened the menu will have selected the region, so that works. But when you're in gain automation mode the right-click won't select the region, so the subsequent activation will be on a perhaps unexpected set of regions.

2007-03-04 23:36

 

bug-1528 (1,085 bytes)   
Index: gtk2_ardour/editor_mouse.cc
===================================================================
--- gtk2_ardour/editor_mouse.cc	(revision 1552)
+++ gtk2_ardour/editor_mouse.cc	(working copy)
@@ -290,7 +290,7 @@
 {
 	bool commit = false;
 
-	/* in object/audition/timefx mode, any button press sets
+	/* in object/audition/timefx/gain-automation mode, any button press sets
 	   the selection if the object can be selected. this is a
 	   bit of hack, because we want to avoid this if the
 	   mouse operation is a region alignment.
@@ -301,6 +301,7 @@
 	if (((mouse_mode != MouseObject) &&
 	     (mouse_mode != MouseAudition || item_type != RegionItem) &&
 	     (mouse_mode != MouseTimeFX || item_type != RegionItem) &&
+	     (mouse_mode != MouseGain) &&
 	     (mouse_mode != MouseRange)) ||
 
 	    (event->type != GDK_BUTTON_PRESS && event->type != GDK_BUTTON_RELEASE || event->button.button > 3)) {
@@ -319,7 +320,7 @@
 			}
 		}
 	}
-	    
+
 	Selection::Operation op = Keyboard::selection_type (event->button.state);
 	bool press = (event->type == GDK_BUTTON_PRESS);
 
bug-1528 (1,085 bytes)   

cth103

2007-03-04 23:37

administrator   ~0003499

I've attached a patch which fixes this for me. Needs to be run past Paul or somebody though!

Cheers

Carl

kjetil

2007-03-05 10:08

reporter   ~0003505

Yes, that fixed it.

seablade

2008-11-24 09:34

manager   ~0005306

Assigned to Paul to check the patch.

     Seablade

paul

2008-11-25 11:47

administrator   ~0005365

patch committed in rev 4252. thanks!

system

2020-04-19 20:12

developer   ~0021500

Issue has been closed automatically, by Trigger Close Plugin.
Feel free to re-open with additional information if you think the issue is not resolved.

Issue History

Date Modified Username Field Change
2007-03-04 10:46 kjetil New Issue
2007-03-04 23:20 cth103 Note Added: 0003498
2007-03-04 23:36 cth103 File Added: bug-1528
2007-03-04 23:37 cth103 Note Added: 0003499
2007-03-05 10:08 kjetil Note Added: 0003505
2008-11-24 08:50 seablade Status new => confirmed
2008-11-24 09:34 seablade Status confirmed => assigned
2008-11-24 09:34 seablade Assigned To => paul
2008-11-24 09:34 seablade Note Added: 0005306
2008-11-25 11:47 paul cost => 0.00
2008-11-25 11:47 paul Status assigned => resolved
2008-11-25 11:47 paul Resolution open => fixed
2008-11-25 11:47 paul Note Added: 0005365
2020-04-19 20:12 system Note Added: 0021500
2020-04-19 20:12 system Status resolved => closed