View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001517ardourbugspublic2007-03-02 15:382008-11-21 00:02
Reporterkjetil Assigned Topaul  
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Summary0001517: Changing the size of effect automation tracks cause graphical rubbish
Description1. Create a gain automation track.
2. Create a pan automation track.
3. Change the size of the gain automation track.
4. The old track separation lines are still there.

Very minor problem. I beg you not to waste time on this if you have important work to do. :-)
TagsNo tags attached.

Activities

kjetil

2007-03-02 15:39

reporter   ~0003468

You need some automation line in the gain track as well for it to happen.

audun

2007-03-20 21:28

reporter   ~0003622

I can confirm this problem. The problem with the separation lines is indeed not as important as other things, but it causes ardour to not look as robust as it actually is.

Another problem, maybe related, is when the automation tracks are children of the last track visible in the editor. Automation tracks have a "track color", that's distinct from the normal tracks and busses that's visible when there are no ghost regions (I think they are called that by looking at the code) present in that particular point of time. This color rectangle has a hard time being redrawn when you edit automation lines and resize the automation tracks, as well as resizing all other tracks above the track in question. I will submit a screenshot showing this problem clearly. The screenshot also shows the separation line redraw problems mentioned in the main bug description.

2007-03-20 21:28

 

ardour_automationproblems.png (91,411 bytes)   
ardour_automationproblems.png (91,411 bytes)   

audun

2007-03-20 21:30

reporter   ~0003623

The above happens with todays svn revision 1631. Maybe this should be fixed before the release candidates start rolling out?

audun

2007-04-27 06:02

reporter   ~0003861

I have a very simple fix for this, although it was not that obvious to figure out. Patch (1 line changed) included. It would be very nice if this was included in 2.0.

2007-04-27 06:02

 

ardour_fix_automation_graphics.patch (638 bytes)    
Index: gtk2_ardour/automation_time_axis.cc
===================================================================
--- gtk2_ardour/automation_time_axis.cc	(revision 1757)
+++ gtk2_ardour/automation_time_axis.cc	(working copy)
@@ -73,7 +73,7 @@
 	base_rect = new SimpleRect(*canvas_display);
 	base_rect->property_x1() = 0.0;
 	base_rect->property_y1() = 0.0;
-	base_rect->property_x2() = max_frames;
+	base_rect->property_x2() = editor.frame_to_pixel (max_frames);
 	base_rect->property_outline_color_rgba() = color_map[cAutomationTrackOutline];
 	/* outline ends and bottom */
 	base_rect->property_outline_what() = (guint32) (0x1|0x2|0x8);
ardour_fix_automation_graphics.patch (638 bytes)   

paul

2007-04-27 11:30

administrator   ~0003862

not actually a minor problem at all. thanks for the patch. committed.

Issue History

Date Modified Username Field Change
2007-03-02 15:38 kjetil New Issue
2007-03-02 15:39 kjetil Note Added: 0003468
2007-03-20 21:28 audun Note Added: 0003622
2007-03-20 21:28 audun File Added: ardour_automationproblems.png
2007-03-20 21:30 audun Note Added: 0003623
2007-04-27 06:02 audun Note Added: 0003861
2007-04-27 06:02 audun File Added: ardour_fix_automation_graphics.patch
2007-04-27 11:30 paul Status new => resolved
2007-04-27 11:30 paul Resolution open => fixed
2007-04-27 11:30 paul Assigned To => paul
2007-04-27 11:30 paul Note Added: 0003862
2008-11-21 00:02 seablade Status resolved => closed