View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001505 | ardour | bugs | public | 2007-02-26 13:39 | 2007-03-13 22:18 |
| Reporter | oofus | Assigned To | cth103 | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Centrino 1.6GHz Laptop | OS | Linux | OS Version | Mandriva 2007 |
| Summary | 0001505: Mouse wheel scrolling seems counter intuative. | ||||
| Description | Roll the mouse wheel forwards and you zoom out. Roll the mouse wheel backwards and you zoom in. This feels to be the wrong way around. | ||||
| Tags | No tags attached. | ||||
|
|
I am inclined to agree with you. I have attached a patch which fixes this. Let me know if it works for you! |
|
|
applied to my source code. will be in my next commit. |
|
|
Huuum, Unless I applied the patch incorrectly, this doesn't seem to have done what I was reporting. Previously ctrl+MouseWheel zoomed in and out of the canvas. Rolling the wheel forwards zoomed out and rolling the wheel backwards zoomed in. This is what I felt was wrong. Shift+MouseWheel changed the height of a track. Rolling the wheel forwards made the track height larger. This I considered to be correct. Having now applied the patch zooming has remained the same but track heights are now reversed, ie rolling forwards now makes the track height smaller. Track heights and zooming are now consistent with each other, but are both now the wrong way around !! |
|
|
I have attached wheel-2 which reverses the previous patch (as it is now in SVN) and hopefully fixes things properly. Would you like to test? (this one will probably need applying with patch -p1 rather than patch -p0) |
|
|
That seems to have fixed it. Everything zooms in and out as I would expect now. Thanks. |
|
|
committed. thanks carl. |
|
|
There seems to be a bit of a side effect from this change. Point the mouse at either the left scroll bar, the track headers or the canvas and roll the mouse wheel and there is different direction of movement, dependant on where the mouse is pointing. Same is true of shift+mousewheel and ctrl+mousewheel. |
|
2007-03-13 00:11
|
wheel-3 (1,520 bytes)
diff --git a/gtk2_ardour/editor_canvas_events.cc b/gtk2_ardour/editor_canvas_events.cc
index 2d91ee4..b7b0288 100644
--- a/gtk2_ardour/editor_canvas_events.cc
+++ b/gtk2_ardour/editor_canvas_events.cc
@@ -52,7 +52,7 @@ Editor::track_canvas_scroll (GdkEventScroll* ev)
double wx, wy;
switch (ev->direction) {
- case GDK_SCROLL_DOWN:
+ case GDK_SCROLL_UP:
if (Keyboard::modifier_state_equals (ev->state, Keyboard::Control)) {
//if (ev->state == GDK_CONTROL_MASK) {
/* XXX
@@ -71,7 +71,7 @@ Editor::track_canvas_scroll (GdkEventScroll* ev)
event.button.y = wy;
nframes_t where = event_frame (&event, 0, 0);
- temporal_zoom_to_frame (true, where);
+ temporal_zoom_to_frame (false, where);
return true;
} else if (Keyboard::modifier_state_equals (ev->state, Keyboard::Shift)) {
if (!current_stepping_trackview) {
@@ -88,7 +88,7 @@ Editor::track_canvas_scroll (GdkEventScroll* ev)
return true;
}
break;
- case GDK_SCROLL_UP:
+ case GDK_SCROLL_DOWN:
if (Keyboard::modifier_state_equals (ev->state, Keyboard::Control)) {
//if (ev->state == GDK_CONTROL_MASK) {
track_canvas.get_pointer (x, y);
@@ -102,7 +102,7 @@ Editor::track_canvas_scroll (GdkEventScroll* ev)
event.button.y = wy;
nframes_t where = event_frame (&event, 0, 0);
- temporal_zoom_to_frame (false, where);
+ temporal_zoom_to_frame (true, where);
return true;
} else if (Keyboard::modifier_state_equals (ev->state, Keyboard::Shift)) {
if (!current_stepping_trackview) {
|
|
|
Cripes! Thank your for your vigilance! I've attached another patch against SVN head. If you could try that it would be great. |
|
|
Patch 3 tested and working. |
|
|
finally ... we hope. |
|
|
Fixed |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-02-26 13:39 | oofus | New Issue | |
| 2007-03-07 18:01 | cth103 | Status | new => assigned |
| 2007-03-07 18:01 | cth103 | Assigned To | => cth103 |
| 2007-03-07 18:01 | cth103 | Note Added: 0003530 | |
| 2007-03-07 18:01 | cth103 | Status | assigned => feedback |
| 2007-03-07 18:02 | cth103 | File Added: wheel-1 | |
| 2007-03-09 13:21 | paul | Note Added: 0003543 | |
| 2007-03-10 14:54 | oofus | Note Added: 0003555 | |
| 2007-03-12 16:15 | cth103 | File Added: test | |
| 2007-03-12 16:16 | cth103 | File Deleted: test | |
| 2007-03-12 16:16 | cth103 | File Deleted: wheel-1 | |
| 2007-03-12 16:16 | cth103 | File Added: wheel-2 | |
| 2007-03-12 16:17 | cth103 | Note Added: 0003560 | |
| 2007-03-12 17:14 | oofus | Note Added: 0003563 | |
| 2007-03-12 17:44 | cth103 | Status | feedback => confirmed |
| 2007-03-12 21:21 | paul | Status | confirmed => resolved |
| 2007-03-12 21:21 | paul | Resolution | open => fixed |
| 2007-03-12 21:21 | paul | Note Added: 0003564 | |
| 2007-03-12 23:22 | oofus | Status | resolved => feedback |
| 2007-03-12 23:22 | oofus | Resolution | fixed => reopened |
| 2007-03-12 23:22 | oofus | Note Added: 0003566 | |
| 2007-03-13 00:10 | cth103 | File Deleted: wheel-2 | |
| 2007-03-13 00:11 | cth103 | File Added: wheel-3 | |
| 2007-03-13 00:12 | cth103 | Note Added: 0003567 | |
| 2007-03-13 00:37 | oofus | Note Added: 0003568 | |
| 2007-03-13 00:38 | cth103 | Status | feedback => confirmed |
| 2007-03-13 12:06 | paul | Status | confirmed => resolved |
| 2007-03-13 12:06 | paul | Resolution | reopened => fixed |
| 2007-03-13 12:06 | paul | Note Added: 0003569 | |
| 2007-03-13 22:18 | oofus | Status | resolved => closed |
| 2007-03-13 22:18 | oofus | Note Added: 0003573 |
