View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001475 | ardour | bugs | public | 2007-02-06 12:21 | 2008-11-20 23:58 |
| Reporter | timbyr | Assigned To | paul | ||
| Priority | low | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0001475: Automation cursor appears when mouse is over an automation point using all editing tools | ||||
| Description | When positioning the mouse pointer over an automation point on an automation track the mouse cursor changes to the automation cursor even though an editing tool is active such as the Range selection tool that does not edit automation. Aswell as the Range selection tool this also occurs when I'm using the Zoom, Stretch/Shrink and playback tool which makes me think I can edit automation using these tools but it isn't possible. | ||||
| Tags | No tags attached. | ||||
|
2007-02-19 12:05
|
automation-cursor.patch (2,214 bytes)
Index: gtk2_ardour/editor_mouse.cc
===================================================================
--- gtk2_ardour/editor_mouse.cc (revision 1463)
+++ gtk2_ardour/editor_mouse.cc (working copy)
@@ -1176,23 +1176,25 @@
case GainAutomationControlPointItem:
case PanAutomationControlPointItem:
case RedirectAutomationControlPointItem:
- cp = static_cast<ControlPoint*>(item->get_data ("control_point"));
- cp->set_visible (true);
-
- double at_x, at_y;
- at_x = cp->get_x();
- at_y = cp->get_y ();
- cp->item->i2w (at_x, at_y);
- at_x += 20.0;
- at_y += 20.0;
+ if (mouse_mode == MouseGain || mouse_mode == MouseObject) {
+ cp = static_cast<ControlPoint*>(item->get_data ("control_point"));
+ cp->set_visible (true);
- fraction = 1.0 - (cp->get_y() / cp->line.height());
-
- set_verbose_canvas_cursor (cp->line.get_verbose_cursor_string (fraction), at_x, at_y);
- show_verbose_canvas_cursor ();
-
- if (is_drawable()) {
- track_canvas.get_window()->set_cursor (*fader_cursor);
+ double at_x, at_y;
+ at_x = cp->get_x();
+ at_y = cp->get_y ();
+ cp->item->i2w (at_x, at_y);
+ at_x += 20.0;
+ at_y += 20.0;
+
+ fraction = 1.0 - (cp->get_y() / cp->line.height());
+
+ set_verbose_canvas_cursor (cp->line.get_verbose_cursor_string (fraction), at_x, at_y);
+ show_verbose_canvas_cursor ();
+
+ if (is_drawable()) {
+ track_canvas.get_window()->set_cursor (*fader_cursor);
+ }
}
break;
@@ -1210,14 +1212,16 @@
case GainAutomationLineItem:
case RedirectAutomationLineItem:
case PanAutomationLineItem:
- {
- ArdourCanvas::Line *line = dynamic_cast<ArdourCanvas::Line *> (item);
- if (line)
- line->property_fill_color_rgba() = color_map[cEnteredAutomationLine];
+ if (mouse_mode == MouseGain || mouse_mode == MouseObject) {
+ {
+ ArdourCanvas::Line *line = dynamic_cast<ArdourCanvas::Line *> (item);
+ if (line)
+ line->property_fill_color_rgba() = color_map[cEnteredAutomationLine];
+ }
+ if (is_drawable()) {
+ track_canvas.get_window()->set_cursor (*fader_cursor);
+ }
}
- if (is_drawable()) {
- track_canvas.get_window()->set_cursor (*fader_cursor);
- }
break;
case RegionViewNameHighlight:
|
|
|
The attached patch should cause the automation tool cursor to be shown when placed over a control point only when the active tool supports automation editing. |
|
|
requesting feedback on the patch |
|
|
patch applied to my source tree. |
|
|
committed. thanks. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-02-06 12:21 | timbyr | New Issue | |
| 2007-02-19 12:05 | timbyr | File Added: automation-cursor.patch | |
| 2007-02-19 12:08 | timbyr | Note Added: 0003316 | |
| 2007-02-19 12:09 | timbyr | Note Added: 0003317 | |
| 2007-02-19 12:09 | timbyr | Status | new => feedback |
| 2007-02-19 16:23 | paul | Note Added: 0003325 | |
| 2007-02-19 20:53 | paul | Status | feedback => resolved |
| 2007-02-19 20:53 | paul | Resolution | open => fixed |
| 2007-02-19 20:53 | paul | Assigned To | => paul |
| 2007-02-19 20:53 | paul | Note Added: 0003327 | |
| 2008-11-20 23:58 | seablade | Status | resolved => closed |
