View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001421 | ardour | bugs | public | 2007-01-12 04:41 | 2008-11-20 23:50 |
| Reporter | puddingpimp | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0001421: Changing time in big-clock window doesn't work | ||||
| Description | When I attempt to change the time in the big-clock window, it usually doesn't allow me to edit it, but when it does (highlights the clock in red), when I type a timecode in and press enter, it doesn't seek the play-head, or alter the recording/playback location. I'm not really sure whether it is supposed to be read-only or whether this is just broken, I haven't checked what it does on ardour 0.99. Also if I try and set the bar in the small clock to 000 it will go to measure 4869|03|0187, whereas I would of expected the sensible behaviour would be to go to 001|01|0000? | ||||
| Additional Information | Using FVWM as window-manager on Gentoo Linux-2.6.17.6, with realtime-lsm. Using jackd-0.101.1 opened with: jackd -R -dalsa -r44100 -i2 -o2 | ||||
| Tags | No tags attached. | ||||
|
|
Attached is a fix for the BBT timecode entry, modified from code in smpte_sanitize_display(), I could of made a separate function, but it seemed so trivial that I just put it inline, and I wasn't sure where in the code listing it belonged if I were to make a new function. I'm not going to attempt to fix the big-clock problem, as it seems a bit too in-depth and intermittent and I'm not really familiar with the ardour code-base. |
|
2007-01-12 05:21
|
BBT.validation.fix.patch (601 bytes)
--- /home/dave/src/orig/ardour-2.0beta10/gtk2_ardour/audio_clock.cc 2007-01-03 06:36:21.000000000 +1300
+++ gtk2_ardour/audio_clock.cc 2007-01-12 18:18:50.000000000 +1300
@@ -745,6 +745,17 @@
// Check SMPTE fields for sanity (may also adjust fields)
smpte_sanitize_display();
break;
+ case Bars:
+ case Beats:
+ case Ticks:
+ // Bars or beats should never be 0
+ if (atoi(bars_label.get_text()) == 0) {
+ bars_label.set_text("001");
+ }
+ if (atoi(beats_label.get_text()) == 0) {
+ beats_label.set_text("01");
+ }
+ break;
default:
break;
}
|
|
|
big clock is already fixed in SVN. |
|
|
patch applied. the bigclock has been made non-editable. thanks. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-01-12 04:41 | puddingpimp | New Issue | |
| 2007-01-12 05:20 | puddingpimp | Note Added: 0003057 | |
| 2007-01-12 05:21 | puddingpimp | File Added: BBT.validation.fix.patch | |
| 2007-01-12 11:52 | paul | Note Added: 0003058 | |
| 2007-01-17 13:36 | paul | Status | new => resolved |
| 2007-01-17 13:36 | paul | Resolution | open => fixed |
| 2007-01-17 13:36 | paul | Assigned To | => paul |
| 2007-01-17 13:36 | paul | Note Added: 0003080 | |
| 2008-11-20 23:50 | seablade | Status | resolved => closed |
