View Issue Details

IDProjectCategoryView StatusLast Update
0001413ardourbugspublic2008-11-21 00:00
Reporternimalr Assigned Tocth103  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0001413: Region context menu operations
DescriptionI have already reported this on the ardour-dev mailing list, but reporting here as well, thinking that this would be the right place.

When the mouse mode is Range, Zoom or Gain, if mouse button 2
is clicked on a region, the context menu is shown without selecting
the corresponding region. Selecting a menu item results in the
operation being performed on the currently selected region (or
no operation if none of the regions is currently selected).


Additional InformationThe code for selecting the corresponding region when the
context menu pops up is commented out.

================= gtk2_ardour/editor.cc line 4219 onwards ==============
        /* when this particular menu pops up, make the relevant region
           become selected.
        */

        // region_menu->signal_map_event().connect (bind (mem_fun(*this, &Editor::set_selected_regionview_from_map_event), sv, boost::weak_ptr<Region>(region)));


TagsNo tags attached.

Relationships

related to 0001603 closedcth103 "remove region" always removes top layer 

Activities

paul

2007-01-17 13:39

administrator   ~0003081

this was commented out because it means that if you context-click on a selected region when more than one is selected, the selection will collapse down to just the one you clicked on.

it appears to me that if you have regions selected and you context click on an *un-selected* region, the intent is ambiguous. i will try to fix up set_selected_regionview_from_map_event() to do the right thing.

nimalr

2007-01-18 00:00

reporter   ~0003083

Related issue: When context-clicked in a place where there are overlapping regions,
the context menu has a submenu for each of the regions. But when selected, the submenu operations apply on one of the regions (the one on top I think ?)

This is applicable to crossfades as well.

cth103

2007-04-11 12:27

administrator   ~0003791

For what it's worth, the Cubase behaviour is that context-click never changes the list of selected regions, so context-click on an unselected region would just leave the selection as-is.

However ardour is different to Cubase in that it offers a context submenu for each region underneath the mouse click, regardless of what the current selection is. I think this is perhaps the cause of the confusion.

Some things we could do (OTTOMH ;):
1. remove the context submenus for each region under the click, and make all right-click menu options operate on the current selection
2. keep the context submenus but ensure that they operate on the correct region without changing the selection (probably by altering Editor::clicked_regionview rather than calling set_selected_regionview_from_map_event()). In this case you could add an extra context submenu for the current selection, perhaps.

Hmm.

cth103

2007-05-10 11:59

administrator   ~0003916

This should all be a bit cleaner in SVN trunk. If you're in a position to test it would be great to hear your feedback.
Thanks
Carl

cth103

2007-05-11 13:35

administrator   ~0003932

I'll mark this as resolved; any bugs introduced by the context menu rearrangement will need to be re-posted to mantis anyway.

Issue History

Date Modified Username Field Change
2007-01-10 05:21 nimalr New Issue
2007-01-17 13:39 paul Note Added: 0003081
2007-01-18 00:00 nimalr Note Added: 0003083
2007-04-11 11:39 cth103 Relationship added related to 0001603
2007-04-11 12:27 cth103 Note Added: 0003791
2007-05-10 11:59 cth103 Note Added: 0003916
2007-05-10 11:59 cth103 Status new => feedback
2007-05-11 13:35 cth103 Status feedback => resolved
2007-05-11 13:35 cth103 Resolution open => fixed
2007-05-11 13:35 cth103 Assigned To => cth103
2007-05-11 13:35 cth103 Note Added: 0003932
2008-11-21 00:00 seablade Status resolved => closed