View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001329 | ardour | bugs | public | 2006-11-16 01:58 | 2007-01-26 19:58 |
| Reporter | oofus | Assigned To | nmains | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Centrino 1.6GHz Laptop | OS | Linux | OS Version | Mandriva 2007 |
| Summary | 0001329: Not all frame rates are counted properly | ||||
| Description | 23.976 counts 23 frames not 24 24.976 counts 24 frames not 25 59.94 counts 59 frames not 60 All other frame rates appear to be correct. | ||||
| Tags | No tags attached. | ||||
|
|
can you expand on this a little? the person who did most of our timecode computation is around but not actively involved in development. it might help to send a message to the ardour-dev mailing list, which i know he still reads. mark it "timecode computation error" :) |
|
|
this should be fixed in current svn. Correct? |
|
|
No it's not fixed. A frame rate of 23.976 still goes from 22 -> 00 when counting frames. |
|
|
I should add that that's probably not the only one. I only tested that frame rate this time to see if it was fixed. |
|
|
hmm. i can't reproduce this. one thing i did notice was that in some zoom levels its not quite clear that every second frame is labeled (the other ones have a small mark). the other possibility is that the framerate selection menu can sometimes introduce illegal combinations of dropframe & framerate. this may be causing strange side effects. maybe this should wait until i've committed the fix to the framerate selection menu. |
|
|
The way I reproduce this is : Start a new session. Select 23.976 from the options menu Set the nudge clock to 00:00:00:01 Click the nudge forward button watch the frame count in the main clock (having first set it to Timecode) You will see frames counted from 00->22 for every second. I started to look at the code and saw that when the timecode type is set, only one value is set, in this case, 23.976. From this both the speed and the count are calculated at the relevent places. Would it be better to set two values when setting the timecode type, frameRate and frameCount. In this example frameRate = 23.976, frameCount = 24.In this way the relevent parts of the code can use the correct values for calculation. I have a feeling 23.976 is being rounded down to 23 for the frameCount ! I could of course be way off target :-) |
|
|
well you weren't too far off :) this should now be fixed in current svn. please confirm. |
|
|
confirmed on IRC |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-11-16 01:58 | oofus | New Issue | |
| 2006-11-16 13:07 | paul | Note Added: 0002786 | |
| 2006-12-11 20:07 | nmains | Note Added: 0002880 | |
| 2006-12-11 20:49 | oofus | Note Added: 0002881 | |
| 2006-12-11 21:02 | oofus | Note Added: 0002882 | |
| 2006-12-12 08:21 | nmains | Note Added: 0002883 | |
| 2006-12-12 10:24 | oofus | Note Added: 0002884 | |
| 2007-01-02 14:08 | nmains | Note Added: 0002970 | |
| 2007-01-02 17:20 | nmains | Status | new => resolved |
| 2007-01-02 17:20 | nmains | Resolution | open => fixed |
| 2007-01-02 17:20 | nmains | Assigned To | => nmains |
| 2007-01-02 17:20 | nmains | Note Added: 0002973 | |
| 2007-01-26 19:58 | oofus | Status | resolved => closed |
