View Issue Details

IDProjectCategoryView StatusLast Update
0001303ardourbugspublic2008-11-20 23:51
Reporterbrianahr Assigned Totaybin  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionwon't fix 
Summary0001303: comment button highlight not applied at startup, if mixer strip contains comments
DescriptionIf a session is loaded, with comments in one or more of the mixer strip comment areas, the comments button does not highlight until the cursor is moved over it.
Additional InformationAttached a patch, for revision 1083.
TagsNo tags attached.

Activities

2006-11-06 22:30

 

highlight-on-load.patch (726 bytes)   
Index: gtk2_ardour/mixer_strip.cc
===================================================================
--- gtk2_ardour/mixer_strip.cc	(revision 1083)
+++ gtk2_ardour/mixer_strip.cc	(working copy)
@@ -231,6 +231,12 @@
 							_("Click to Add/Edit Comments"):
 							_route->comment());
 
+	if (! _route->comment().empty()) {
+		comment_button.set_state (Gtk::STATE_ACTIVE);
+	} else {
+		comment_button.set_state (Gtk::STATE_NORMAL);
+	}
+
 	comment_button.signal_clicked().connect (mem_fun(*this, &MixerStrip::comment_button_clicked));
 	comment_button.signal_enter().connect (mem_fun(*this, &MixerStrip::comment_button_refresh));
 	comment_button.signal_leave().connect (mem_fun(*this, &MixerStrip::comment_button_refresh));
highlight-on-load.patch (726 bytes)   

taybin

2006-11-09 19:29

administrator   ~0002731

Well, the previous change was backed out. They're going to fix it using gtk themes, I believe. So this patch is moot. Thanks anyways though!

Issue History

Date Modified Username Field Change
2006-11-06 22:30 brianahr New Issue
2006-11-06 22:30 brianahr File Added: highlight-on-load.patch
2006-11-07 15:50 taybin Status new => assigned
2006-11-07 15:50 taybin Assigned To => taybin
2006-11-09 19:29 taybin Status assigned => resolved
2006-11-09 19:29 taybin Resolution open => won't fix
2006-11-09 19:29 taybin Note Added: 0002731
2008-11-20 23:51 seablade Status resolved => closed