View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001290 | ardour | bugs | public | 2006-11-03 16:36 | 2020-04-19 20:12 |
| Reporter | BenLoftis | Assigned To | cth103 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0001290: Grabbing the text display inside a region moves the region instead of trimming start and end times | ||||
| Description | SVN 1067 Grabbing the "text" of a region with the mouse will move the region as if you had grabbed inside the waveform area. Actually it should allow you to adjust the start and end trim. In other words it should be transparent as far as mouse input is concerned. This is especially annoying when the region is zoomed such that the text is the full width of the region. In this case it is very difficult to grab the start and end points of the region for trimming. | ||||
| Tags | No tags attached. | ||||
|
|
Maybe this is just a layering thing and the text can be pushed down a level to be below the trim area. |
|
|
then it would be hard to read. the origins of this issue are that i wanted to be edit region names by clicking on the name text. it works. but if the text works for button press/release, something fancier has to happen to proxy the event down to the trim area for motion events. |
|
|
Another option (borrowing from other DAWs) might be to allow trimming the region whenever the mouse is very close to the side of the region. Although I like the larger target that the current system provides, I think this is a case where sticking with an established convention might work better. |
|
|
I agree with BenLoftis for an other reason. when zoomed such as only a part of the region is show on screen (and you don't see the border), if you intend to move the region an unintentionnaly click on the text strip, you'll trim the borders without being able to notice it. If trimming the borders implies being near the edge, it would make things more explicit. |
|
|
As 2.7.1, editing region names by clicking on them (under the waveform display) does not work. I also vote for making the name text indifferent for mouse input, ie. be able to trim by clicking or dragging on the full length of the name strip below the waveform display. |
|
|
Something strange is going on here; when moving the mouse over the actual name text of a region, the cursor flicks between that for moving the region and for trimming it. As the mouse is moved over the name, lots of enter/leave events are being generated for the RegionViewNameHighlight. |
|
|
This started to happen when the region name drawing method was changed to using Cairo, only the text lines of the characters cause a 'move' action, the background is considered a trim. |
|
|
+5 insightful chris :) The attached patch improves things a bit; how is this for everyone? |
|
2009-10-29 00:08
|
1290.patch (542 bytes)
diff --git a/gtk2_ardour/region_view.cc b/gtk2_ardour/region_view.cc
index 47d0c38..8d469a9 100644
--- a/gtk2_ardour/region_view.cc
+++ b/gtk2_ardour/region_view.cc
@@ -145,6 +145,7 @@ RegionView::init (Gdk::Color& basic_color, bool wfd)
if (name_pixbuf) {
name_pixbuf->set_data ("regionview", this);
+ name_pixbuf->signal_event().connect (bind (mem_fun (PublicEditor::instance(), &PublicEditor::canvas_region_view_name_event), name_pixbuf, this));
}
reset_width_dependent_items ((double) _region->length() / samples_per_unit);
|
|
|
The patch has been applied to A3. Any comments on whether this can be considered fixed? |
|
|
fixed in A2 |
|
|
Thanks. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-11-03 16:36 | BenLoftis | New Issue | |
| 2006-11-03 17:06 | taybin | Note Added: 0002636 | |
| 2006-11-03 22:13 | paul | Note Added: 0002653 | |
| 2006-11-03 22:59 | BenLoftis | Note Added: 0002654 | |
| 2006-11-09 19:41 | atreju | Note Added: 0002733 | |
| 2009-01-29 18:22 | wferi | Note Added: 0005680 | |
| 2009-10-28 23:21 | cth103 | Note Added: 0006924 | |
| 2009-10-28 23:21 | cth103 | Status | new => confirmed |
| 2009-10-28 23:45 | oofus | Note Added: 0006926 | |
| 2009-10-29 00:08 | cth103 | Note Added: 0006927 | |
| 2009-10-29 00:08 | cth103 | File Added: 1290.patch | |
| 2009-10-29 00:08 | cth103 | Note Edited: 0006927 | |
| 2010-04-18 22:14 | cth103 | Note Added: 0007509 | |
| 2010-04-18 22:14 | cth103 | Status | confirmed => feedback |
| 2010-04-26 22:26 | BenLoftis | Note Added: 0007605 | |
| 2010-04-26 22:51 | cth103 | cost | => 0.00 |
| 2010-04-26 22:51 | cth103 | Note Added: 0007607 | |
| 2010-04-26 22:51 | cth103 | Status | feedback => resolved |
| 2010-04-26 22:51 | cth103 | Resolution | open => fixed |
| 2010-04-26 22:51 | cth103 | Assigned To | => cth103 |
| 2020-04-19 20:12 | system | Note Added: 0021487 | |
| 2020-04-19 20:12 | system | Status | resolved => closed |
