View Issue Details

IDProjectCategoryView StatusLast Update
0001288ardourbugspublic2008-11-20 23:47
Reporterbrianahr Assigned Tov2  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0001288: Can't close the About dialog
DescriptionThe Close button does not work on the About dialog. Consequently, the only way to get rid of it is to close Ardour, since the dialog is set to WINDOW_TYPE_HINT_SPLASHSCREEN, and thus has no window manager close button, and is always on top. Also, the window always appears in the far top-left of the screen, and would probably be better in the center of the screen.
Steps To ReproduceStart Ardour
Windows -> About
Click the dialog's close button

Desired Result: Close button should hide the dialog
Additional InformationThis could be my setup, which is GTK+ 2.10.6. I noticed that the gtkmm in libs/ is 2.6.1, which may or may not be fully compatible with such a new gtk version? Since the about dialog is a standard Gtk::AboutDialog, the close button should work out of the box, yes?
TagsNo tags attached.

Activities

taybin

2006-11-03 06:11

administrator   ~0002622

gtkmm 2.6 is fully compatible with gtk 2.10. Although we should probably upgrade it and the others sometime.

paul

2006-11-03 14:39

administrator   ~0002632

i can't replicate the "cannot close" issue.

the position of the window isn't set, i'll make it default to screen center, but note that for some xinerama configurations this is not a good thing either.

how are you getting the About dialog to appear? just normal program startup, or opening it from the "Windows" menu ? And yes,it should be under "Help"

2006-11-03 21:08

 

brianahr

2006-11-03 21:13

developer   ~0002648

Ive a attached a theora capture of what happens (no sound though). Ive gone through the source code, but havent seen anything that looks like it could be causing this issue. Ive been accessing the dialog just through the windows menu, as per the attached video.

Here is my setup:
Ardour r1066, compiled with DEBUG=1, PREFIX=/opt/ardour2
Gtk+ 2.10.6.
Xfce 4.2.3.2

brianahr

2006-11-03 22:05

developer   ~0002650

Ok. Did a little research. Check this out: http://www.gtk.org/gtk-2.10-notes.html

--snip--
* Dialogs created by gtk_about_dialog_new() no longer hide automatically
  when the user clicks close. It is the applications responsibility to
  hide or destroy the dialog.
--snip--

Seems like Anjuta had the same problem.

paul

2006-11-03 22:08

administrator   ~0002651

thats it then. i'll do an explicit close. it would be worth pondering which other dialogs might have this issue.

brianahr

2006-11-03 23:25

developer   ~0002656

Ive tested all other dialogs I can find. Most dont have their own 'Close' buttons, and thus need to be closed with the window manager's close button - so this problem doesnt seem to apply the remaining dialogs. It looks like the gtk guys just changed the AboutDialog functionality.

taybin

2006-11-05 15:27

administrator   ~0002663

Fixed by sampo.

Issue History

Date Modified Username Field Change
2006-11-03 05:50 brianahr New Issue
2006-11-03 06:11 taybin Note Added: 0002622
2006-11-03 14:39 paul Note Added: 0002632
2006-11-03 21:08 brianahr File Added: aboutdialogproblems.theora.ogg
2006-11-03 21:13 brianahr Note Added: 0002648
2006-11-03 22:05 brianahr Note Added: 0002650
2006-11-03 22:08 paul Note Added: 0002651
2006-11-03 23:25 brianahr Note Added: 0002656
2006-11-04 02:12 taybin Summary Cant close the About dialog => Can't close the About dialog
2006-11-05 15:27 taybin Status new => assigned
2006-11-05 15:27 taybin Assigned To => v2
2006-11-05 15:27 taybin Note Added: 0002663
2006-11-05 15:27 taybin Status assigned => resolved
2006-11-05 15:27 taybin Resolution open => fixed
2008-11-20 23:47 seablade Status resolved => closed