View Issue Details

IDProjectCategoryView StatusLast Update
0001179ardourbugspublic2008-11-20 23:48
Reportermschwarzenberg Assigned Tov2  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version0.99 
Summary0001179: splitting destroys adjacent crossfade
DescriptionSteps to reproduce:

* create a crossfade, type: full, edit its shape
* split one of the involved regions via "s" (split-at-mouse)
* the crosfade gets lost (ie: muted, default type),
  when re-enabling the crossfade and converting it to full
  the former shape edit is lost.
  
I'd think splitting regions should retain the crossfade(s) (if
the split position doesn't overlap with the fades, of course).

Happens with ardour0.99.cvs as of 2006/01/19 (where the splitting
undo issue already is fixed).
TagsNo tags attached.

Activities

2006-03-14 09:48

 

mschwarzenberg

2006-03-14 09:55

reporter   ~0002457

Last edited: 2006-03-20 16:19

The attachment split-retain-xfades.diff.gz (against 0.99.2, also applicable to ardour2.0-alpha2) is an attempt to fix this issue. Should be reviewed before finally included.
Notes:
* States of the xfades wich are going to be destroyed by the split are collected in the new Playlist member _splited_xfades. It could be desirable to use an old StateManager state instead.
* Only xfades not overlapping with the split position are restored.
* restortion is done in AudioPlaylist::check_dependents
* adding save_state("set state") in Crossfade::set_state was necessary to make undo work correctly.

v2

2006-03-20 22:15

developer   ~0002461

Fixed in CVS for both ardour 0.99 & 2.0. Please test.

Issue History

Date Modified Username Field Change
2006-01-27 13:23 mschwarzenberg New Issue
2006-03-14 09:48 mschwarzenberg File Added: split-retain-xfades.diff.gz
2006-03-14 09:55 mschwarzenberg Note Added: 0002457
2006-03-14 09:56 mschwarzenberg Note Edited: 0002457
2006-03-20 16:19 mschwarzenberg Note Edited: 0002457
2006-03-20 22:14 v2 Status new => assigned
2006-03-20 22:14 v2 Assigned To => v2
2006-03-20 22:15 v2 Status assigned => resolved
2006-03-20 22:15 v2 Resolution open => fixed
2006-03-20 22:15 v2 Note Added: 0002461
2008-11-20 23:48 seablade Status resolved => closed