View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001106ardourbugspublic2005-09-30 14:252008-11-20 23:51
Reporterccomb Assigned Totaybin  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version0.99 
Summary0001106: editor mixer button in the wrong state (was solved, but still present in 0.99)
DescriptionThis bug is marked as solved, but is still in 0.99 :
http://ardour.org/mantis/view.php?id=265


- click on the "editor mixer" button to make the strip appear
- close the strip with the "x" button on the strip.

=> the "editor mixer" button remains orange and pressed,
instead of being released.
TagsNo tags attached.

Activities

2006-11-05 03:51

 

ardour-b1106-r1070.patch (460 bytes)    
Index: gtk2_ardour/mixer_strip.cc
===================================================================
--- gtk2_ardour/mixer_strip.cc  (revision 1070)
+++ gtk2_ardour/mixer_strip.cc  (working copy)
@@ -1085,7 +1085,9 @@
        if (_embedded) {
                 Hiding(); /* EMIT_SIGNAL */
        } else {
+               hide_button.set_sensitive(false);
                _mixer.hide_strip (this);
+               hide_button.set_sensitive(true);
        }
 }
ardour-b1106-r1070.patch (460 bytes)   

brianahr

2006-11-05 03:52

developer   ~0002661

Last edited: 2006-11-05 05:15

 This bug is also present in the svn version of ardour. This patch fixes the svn version, but a similar fix will probably work for the 0.99.x series as well. Ignore the first patch (it only fixes the mixer window, not the editor mixer) second patch fixes both the mixer strips in the mixer window and the editor mixer strip.

2006-11-05 05:13

 

ardour-b1106-r1070-a.patch (484 bytes)    
Index: gtk2_ardour/mixer_strip.cc
===================================================================
--- gtk2_ardour/mixer_strip.cc  (revision 1070)
+++ gtk2_ardour/mixer_strip.cc  (working copy)
@@ -1082,11 +1082,13 @@
 void
 MixerStrip::hide_clicked ()
 {
+       hide_button.set_sensitive(false);
        if (_embedded) {
                 Hiding(); /* EMIT_SIGNAL */
        } else {
                _mixer.hide_strip (this);
        }
+       hide_button.set_sensitive(true);
 }
ardour-b1106-r1070-a.patch (484 bytes)   

brianahr

2006-11-06 21:15

developer   ~0002692

Looks like there is a similar problem with the "hide this track" button is under each track's name. The same fix can be applied to gtk2_ardour/visual_time_axis.cc and gtk2_ardour/route_time_axis.cc in the hide_click() method.

taybin

2006-11-13 00:51

administrator   ~0002755

It seems the editor-mixer button has been removed.

taybin

2006-11-13 01:57

administrator   ~0002757

I'm using the set_sensitive() fix in mixer_strips, route_time_axis.cc, visual_time_axis.cc, and automation_time_axis.cc.

Issue History

Date Modified Username Field Change
2005-09-30 14:25 ccomb New Issue
2006-11-05 03:51 brianahr File Added: ardour-b1106-r1070.patch
2006-11-05 03:52 brianahr Note Added: 0002661
2006-11-05 03:55 brianahr Note Edited: 0002661
2006-11-05 05:13 brianahr File Added: ardour-b1106-r1070-a.patch
2006-11-05 05:15 brianahr Note Edited: 0002661
2006-11-06 13:01 taybin Status new => assigned
2006-11-06 13:01 taybin Assigned To => taybin
2006-11-06 21:15 brianahr Note Added: 0002692
2006-11-13 00:51 taybin Note Added: 0002755
2006-11-13 01:57 taybin Status assigned => resolved
2006-11-13 01:57 taybin Resolution open => fixed
2006-11-13 01:57 taybin Note Added: 0002757
2008-11-20 23:51 seablade Status resolved => closed