View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001011 | ardour | features | public | 2005-06-18 02:40 | 2008-11-20 23:47 |
| Reporter | matalos2 | Assigned To | taybin | ||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0001011: Make the "comments" button at the bottom of each mixer strip a bit more useful | ||||
| Description | I just recently found out that hovering over the "comments" button of a mixer strip, pops up the contents of the comments edit box. Cool! I didn't know that! Still, this not very practical if you have a lot of tracks and / or busses and you don't know which mixer strip has comments included. I suggest that when a mixer strip has some comments written, the "comments" button should have a different colour and/or font. This way the Ardour user would quickly find if a track or bus has any comments info. | ||||
| Tags | No tags attached. | ||||
|
|
I think that's a great idea, it would be really useful to me. |
|
|
That is a good idea. |
|
2006-11-05 01:48
|
ardour-b1011-r1070.patch (1,685 bytes)
Index: gtk2_ardour/mixer_strip.cc
===================================================================
--- gtk2_ardour/mixer_strip.cc (revision 1070)
+++ gtk2_ardour/mixer_strip.cc (working copy)
@@ -232,6 +232,8 @@
_route->comment());
comment_button.signal_clicked().connect (mem_fun(*this, &MixerStrip::comment_button_clicked));
+ comment_button.signal_enter().connect (mem_fun(*this, &MixerStrip::comment_button_refresh));
+ comment_button.signal_leave().connect (mem_fun(*this, &MixerStrip::comment_button_refresh));
global_vpacker.set_border_width (0);
global_vpacker.set_spacing (0);
@@ -759,6 +761,12 @@
Gtkmm2ext::UI::instance()->call_slot (mem_fun(*this, &MixerStrip::update_output_display));
}
+void
+MixerStrip::comment_button_refresh() {
+ if (! _route->comment().empty())
+ comment_button.set_state (Gtk::STATE_ACTIVE);
+}
+
void
MixerStrip::comment_editor_done_editing() {
string str = comment_area->get_buffer()->get_text();
@@ -787,6 +795,11 @@
ARDOUR_UI::instance()->tooltips().set_tip (comment_button,
str.empty() ? _("Click to Add/Edit Comments") : str);
}
+
+ if (! _route->comment().empty())
+ comment_button.set_state (Gtk::STATE_ACTIVE);
+ else
+ comment_button.set_state (Gtk::STATE_NORMAL);
}
void
Index: gtk2_ardour/mixer_strip.h
===================================================================
--- gtk2_ardour/mixer_strip.h (revision 1070)
+++ gtk2_ardour/mixer_strip.h (working copy)
@@ -153,6 +153,7 @@
Gtk::TextView* comment_area;
Gtk::Button comment_button;
+ void comment_button_refresh();
void comment_editor_done_editing();
void setup_comment_editor ();
void comment_button_clicked ();
|
|
|
taybin, sorry if this one is on your turf, just thought Id share my thoughts on it with you. |
|
|
Looks like a good patch to me. I'm adding in some extra curly brackets, and then committing. Thanks. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-06-18 02:40 | matalos2 | New Issue | |
| 2005-06-18 08:02 | ericsean | Note Added: 0002270 | |
| 2006-11-03 06:21 | taybin | Status | new => assigned |
| 2006-11-03 06:21 | taybin | Assigned To | => taybin |
| 2006-11-03 06:21 | taybin | Note Added: 0002628 | |
| 2006-11-03 06:21 | taybin | Status | assigned => acknowledged |
| 2006-11-05 01:48 | brianahr | File Added: ardour-b1011-r1070.patch | |
| 2006-11-05 01:49 | brianahr | Note Added: 0002660 | |
| 2006-11-06 17:07 | taybin | Status | acknowledged => resolved |
| 2006-11-06 17:07 | taybin | Resolution | open => fixed |
| 2006-11-06 17:07 | taybin | Note Added: 0002670 | |
| 2008-11-20 23:47 | seablade | Status | resolved => closed |
