View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004655 | ardour | bugs | public | 2012-01-24 22:26 | 2015-09-18 15:14 |
| Reporter | colinf | Assigned To | paul | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Target Version | 3.0-beta3 | ||||
| Summary | 0004655: [PATCH] Generic scrollable plugin UI windows are too narrow | ||||
| Description | The 'generic' scrollable plugin window that is shown via 'Edit with basic controls...' is too narrow to show all the controls of plugins with toggle switches or meters without horizontal scrolling. | ||||
| Additional Information | Attached the trivial patch to remove the horizontal scroll bar of generic scrollable plugin UIs, so that they rather automatically size themselves as wide as they need to be to fit all controls. | ||||
| Tags | No tags attached. | ||||
|
2012-01-24 22:26
|
generic-plugin-ui-no-hscroll.patch (922 bytes)
Index: gtk2_ardour/plugin_ui.cc
===================================================================
--- gtk2_ardour/plugin_ui.cc (revision 11340)
+++ gtk2_ardour/plugin_ui.cc (working copy)
@@ -156,11 +156,6 @@
if (scrollable) {
if (h > 600) h = 600;
- if (w > 600) w = 600;
-
- if (w < 0) {
- w = 450;
- }
}
set_default_size (w, h);
Index: gtk2_ardour/generic_pluginui.cc
===================================================================
--- gtk2_ardour/generic_pluginui.cc (revision 11340)
+++ gtk2_ardour/generic_pluginui.cc (working copy)
@@ -113,7 +113,7 @@
main_contents.pack_start (*constraint_hbox, false, false);
if (is_scrollable ) {
- scroller.set_policy (Gtk::POLICY_AUTOMATIC, Gtk::POLICY_AUTOMATIC);
+ scroller.set_policy (Gtk::POLICY_NEVER, Gtk::POLICY_AUTOMATIC);
scroller.set_name ("PluginEditor");
scroller_view.set_name("PluginEditor");
scroller_view.add (hpacker);
|
|
|
accidentally committed near 11398 or so. thanks as usual! |
|
|
Are you sure you committed this? I can't see it in svn yet. |
|
|
Closing old issues reported by me: these have long since been fixed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-01-24 22:26 | colinf | New Issue | |
| 2012-01-24 22:26 | colinf | File Added: generic-plugin-ui-no-hscroll.patch | |
| 2012-01-26 08:53 | cth103 | cost | => 0.00 |
| 2012-01-26 08:53 | cth103 | Target Version | => 3.0-beta3 |
| 2012-01-31 02:00 | paul | Note Added: 0012717 | |
| 2012-01-31 02:00 | paul | Status | new => resolved |
| 2012-01-31 02:00 | paul | Resolution | open => fixed |
| 2012-01-31 02:00 | paul | Assigned To | => paul |
| 2012-01-31 16:42 | colinf | Note Added: 0012725 | |
| 2015-09-18 15:14 | colinf | Note Added: 0017256 | |
| 2015-09-18 15:14 | colinf | Status | resolved => closed |
