View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004625 | ardour | bugs | public | 2012-01-10 17:53 | 2019-05-21 11:29 |
| Reporter | colinf | Assigned To | colinf | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Target Version | 3.0-beta3 | ||||
| Summary | 0004625: Double-clicking aux sends in processor box doesn't assign the send to the channel's main fader any more. | ||||
| Description | Double-clicking on an aux send in the channel strip processor box used (as I remember) to assign control of that aux send to the channel's main fader, but that doesn't seem to work any more. | ||||
| Tags | No tags attached. | ||||
|
2012-01-19 13:42
|
double-click-send.patch (578 bytes)
Index: gtk2_ardour/processor_box.cc
===================================================================
--- gtk2_ardour/processor_box.cc (revision 11268)
+++ gtk2_ardour/processor_box.cc (working copy)
@@ -1830,6 +1830,11 @@
if (boost::dynamic_pointer_cast<InternalSend> (processor) == 0) {
SendUIWindow* w = new SendUIWindow (send, _session);
w->show ();
+ } else {
+ /* assign internal send to main fader */
+ if (_parent_strip) {
+ _parent_strip->show_send(send);
+ }
}
} else if ((retrn = boost::dynamic_pointer_cast<Return> (processor)) != 0) {
|
|
|
Attached a tiny patch that makes this work again for me. |
|
|
A couple of other related things: - ProcessorBox::show_send_controls () and ProcessorBox::new_send () are empty and unused: were they supposed to be used to implement this functionality, or are they just vestigial remains of something else? - currently, double-clicks of internal & external sends behave quite differently. Is it possible to assign a channel's main fader to an external send in the same way as an internal one, and if so, is there any reason why showing the external send's editor in response to a double-click is a better thing to do than being consistent with internal sends' behaviour? |
|
|
::show_send_controls() is related to the functionality that your patch restores. ::new_send() is vestigial. internal sends require careful work, because we have both Aux internal sends and Listen internal sends. Aux can be mapped to the strip; Listen cannot. |
|
|
Thanks for applying this. If I do start to find myself getting irritated or confused by the difference in double-click behaviour between internal & external sends, I'll open a new issue for that. |
|
|
Closing this ancient issue: resolved a long time ago. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-01-10 17:53 | colinf | New Issue | |
| 2012-01-10 20:44 | cth103 | cost | => 0.00 |
| 2012-01-10 20:44 | cth103 | Target Version | => 3.0-beta3 |
| 2012-01-19 13:42 | colinf | File Added: double-click-send.patch | |
| 2012-01-19 13:49 | colinf | Note Added: 0012577 | |
| 2012-01-19 13:59 | colinf | Note Added: 0012578 | |
| 2012-01-20 03:08 | paul | Note Added: 0012587 | |
| 2012-01-21 23:16 | colinf | Note Added: 0012609 | |
| 2012-01-21 23:16 | colinf | Status | new => resolved |
| 2012-01-21 23:16 | colinf | Resolution | open => fixed |
| 2012-01-21 23:16 | colinf | Assigned To | => colinf |
| 2019-05-21 11:29 | colinf | Status | resolved => closed |
| 2019-05-21 11:29 | colinf | Note Added: 0020662 |
