View Issue Details

IDProjectCategoryView StatusLast Update
0004564ardourbugspublic2015-09-18 15:14
Reportercolinf Assigned Topaul  
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Target Version3.0-beta3 
Summary0004564: 'Name new markers' (and maybe other) prompters don't respond to <Enter> or <Esc> until the text is edited.
DescriptionTo reproduce:
* enable 'Name new markers'.
* press num-pad enter to create a new marker.
* <Enter> and <Esc> don't work until you've edited the default marker name.
Additional InformationTiny patch attached to allow Gtkmm2ext::Prompter to respond immediately to these key presses if the default response is not empty. I don't know if this is the right place to fix this, but it works for me.
TagsNo tags attached.

Activities

2011-12-14 18:22

 

gtkmm-prompter-allow-accept-without-edit.patch (481 bytes)   
Index: libs/gtkmm2ext/prompter.cc
===================================================================
--- libs/gtkmm2ext/prompter.cc	(revision 11005)
+++ libs/gtkmm2ext/prompter.cc	(working copy)
@@ -86,6 +86,7 @@
 	if (first_show) {
 		entry.signal_changed().connect (mem_fun (*this, &Prompter::on_entry_changed));
 		entry.signal_activate().connect (mem_fun (*this, &Prompter::entry_activated));
+		can_accept_from_entry = !entry.get_text().empty();
 		first_show = false;
 	}
 

paul

2011-12-30 01:41

administrator   ~0012492

applied, rev 11112. thanks as usual.

colinf

2015-09-18 15:14

updater   ~0017263

Closing old issues reported by me: these have long since been fixed.

Issue History

Date Modified Username Field Change
2011-12-14 18:22 colinf New Issue
2011-12-14 18:22 colinf File Added: gtkmm-prompter-allow-accept-without-edit.patch
2011-12-15 12:13 cth103 cost => 0.00
2011-12-15 12:13 cth103 Target Version => 3.0-beta2
2011-12-30 01:41 paul Note Added: 0012492
2011-12-30 01:41 paul Status new => resolved
2011-12-30 01:41 paul Resolution open => fixed
2011-12-30 01:41 paul Assigned To => paul
2012-01-10 20:45 cth103 Target Version 3.0-beta2 => 3.0-beta3
2015-09-18 15:14 colinf Note Added: 0017263
2015-09-18 15:14 colinf Status resolved => closed