View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004506 | ardour | bugs | public | 2011-11-23 10:50 | 2015-09-18 15:14 |
| Reporter | colinf | Assigned To | cth103 | ||
| Priority | normal | Severity | minor | Reproducibility | sometimes |
| Status | closed | Resolution | fixed | ||
| Summary | 0004506: Build fails with gtkmm older than 2.28 | ||||
| Description | r10788 uses an overloaded version of Glib::build_filename() that, according to http://developer.gnome.org/glibmm/unstable/group__MiscUtils.html, was only introduced in libglibmm 2.28. I'm using Ubuntu 10.04, where the libglibmm version is still 2.24.2-0ubuntu1. | ||||
| Additional Information | Trivial patch attached that I think does the equivalent thing for older glibmm versions. | ||||
| Tags | No tags attached. | ||||
|
2011-11-23 10:50
|
older-glibmm.patch (510 bytes)
Index: libs/ardour/lv2_plugin_lilv.cc =================================================================== --- libs/ardour/lv2_plugin_lilv.cc (revision 10790) +++ libs/ardour/lv2_plugin_lilv.cc (working copy) @@ -581,8 +581,10 @@ } const std::string abs_path = Glib::build_filename( - me->_session.plugins_dir(), - me->_insert_id.to_s(), + Glib::build_filename( + me->_session.plugins_dir(), + me->_insert_id.to_s() + ), path); const std::string dirname = Glib::path_get_dirname(abs_path); |
|
|
Incidentally, the build failure looks like: ../libs/ardour/lv2_plugin_lilv.cc: In static member function ‘static char* ARDOUR::LV2Plugin::lv2_state_make_path(void*, const char*)’: ../libs/ardour/lv2_plugin_lilv.cc:586:7: error: no matching function for call to ‘build_filename(std::string, std::string, const char*&)’ /usr/include/glibmm-2.4/glibmm/miscutils.h:244:13: note: candidates are: std::string Glib::build_filename(const Glib::ArrayHandle<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, Glib::Container_Helpers::TypeTraits<std::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&) /usr/include/glibmm-2.4/glibmm/miscutils.h:253:13: note: std::string Glib::build_filename(const std::string&, const std::string&) |
|
|
Applied to SVN 10791. Thanks! |
|
|
Closing old issues reported by me: these have long since been fixed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-11-23 10:50 | colinf | New Issue | |
| 2011-11-23 10:50 | colinf | File Added: older-glibmm.patch | |
| 2011-11-23 10:52 | colinf | Note Added: 0012184 | |
| 2011-11-23 13:27 | cth103 | cost | => 0.00 |
| 2011-11-23 13:27 | cth103 | Note Added: 0012186 | |
| 2011-11-23 13:27 | cth103 | Status | new => resolved |
| 2011-11-23 13:27 | cth103 | Resolution | open => fixed |
| 2011-11-23 13:27 | cth103 | Assigned To | => cth103 |
| 2015-09-18 15:14 | colinf | Note Added: 0017268 | |
| 2015-09-18 15:14 | colinf | Status | resolved => closed |
