View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004459 | ardour | features | public | 2011-11-08 18:39 | 2015-09-18 15:19 |
| Reporter | colinf | Assigned To | paul | ||
| Priority | normal | Severity | tweak | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Target Version | 3.0 | ||||
| Summary | 0004459: 'Enter' should confirm/dismiss more dialogs | ||||
| Description | There are still a number of dialogs in A3 which don't respond to the 'Enter' key which I think probably should: e.g. missing plugin dialog new plugin preset dialog missing file dialog time fx dialog quantize dialog strip silence dialog and probably plenty more. | ||||
| Additional Information | Attached the trivial patch to make it so for the first three of these. The others are not so straightforward for someone such as me who knows little of GTK: making those work requires working out how to make Gtk::ComboBox not pop up its item list on 'Enter', making ARDOUR::AudioClock pass on 'Enter' key presses unhandled in the appropriate place, and more, which I haven't done (yet). | ||||
| Tags | No tags attached. | ||||
|
2011-11-08 18:39
|
enter-confirms-more-dialogs.patch (1,238 bytes)
Index: gtk2_ardour/missing_plugin_dialog.cc
===================================================================
--- gtk2_ardour/missing_plugin_dialog.cc (revision 10493)
+++ gtk2_ardour/missing_plugin_dialog.cc (working copy)
@@ -32,6 +32,7 @@
set_session (s);
add_button (_("OK"), RESPONSE_OK);
+ set_default_response (RESPONSE_OK);
Label* m = manage (new Label);
Index: gtk2_ardour/new_plugin_preset_dialog.cc
===================================================================
--- gtk2_ardour/new_plugin_preset_dialog.cc (revision 10499)
+++ gtk2_ardour/new_plugin_preset_dialog.cc (working copy)
@@ -41,6 +41,8 @@
add_button (Stock::CANCEL, RESPONSE_CANCEL);
_add = add_button (Stock::ADD, RESPONSE_ACCEPT);
+ set_default_response (RESPONSE_ACCEPT);
+ _name.set_activates_default(true);
show_all ();
Index: gtk2_ardour/missing_file_dialog.cc
===================================================================
--- gtk2_ardour/missing_file_dialog.cc (revision 10493)
+++ gtk2_ardour/missing_file_dialog.cc (working copy)
@@ -43,6 +43,7 @@
set_session (s);
add_button (_("Done"), RESPONSE_OK);
+ set_default_response (RESPONSE_OK);
string typestr;
|
|
|
patch committed, svn rev 10505 |
|
|
Time FX and strip silence dialogues fixed as of 10583. The quantize dialogue is trickier; we don't want to disable the action of enter on the combobox (as it allows keyboard navigation), and we don't want to set "OK" as the initially focussed widget, so I think that will probably have to stay as it is. Unless you have any suggestions. |
|
|
see notes. |
|
|
Closing old issues reported by me: these have long since been fixed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-11-08 18:39 | colinf | New Issue | |
| 2011-11-08 18:39 | colinf | File Added: enter-confirms-more-dialogs.patch | |
| 2011-11-09 09:03 | cth103 | cost | => 0.00 |
| 2011-11-09 09:03 | cth103 | Target Version | => 3.0-beta1 |
| 2011-11-09 09:03 | cth103 | Summary | 'Enter' should confirm/dismiss more dialogs => [PATCH] 'Enter' should confirm/dismiss more dialogs |
| 2011-11-09 10:58 | paul | Note Added: 0011955 | |
| 2011-11-14 13:45 | cth103 | Note Added: 0011995 | |
| 2011-11-14 13:45 | cth103 | Target Version | 3.0-beta1 => 3.0 |
| 2011-11-14 13:45 | cth103 | Summary | [PATCH] 'Enter' should confirm/dismiss more dialogs => 'Enter' should confirm/dismiss more dialogs |
| 2012-04-19 19:17 | paul | Note Added: 0013142 | |
| 2012-04-19 19:17 | paul | Status | new => resolved |
| 2012-04-19 19:17 | paul | Resolution | open => fixed |
| 2012-04-19 19:17 | paul | Assigned To | => paul |
| 2015-09-18 15:19 | colinf | Note Added: 0017302 | |
| 2015-09-18 15:19 | colinf | Status | resolved => closed |
