View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002853 | ardour | bugs | public | 2009-10-03 17:13 | 2010-10-17 13:31 |
| Reporter | oofus | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Dell D830 core2duo T9300 2.5GHz | OS | Mandriva | OS Version | 2009.1 |
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002853: Inbound MMC Device ID is always initialised to 0, should be 127. | ||||
| Description | In the Midi tab of the Preferences window the Inbound MMC Device ID is always initialised to 0 instead of 127. Outbound is initialised correctly. | ||||
| Tags | No tags attached. | ||||
|
2009-10-12 21:21
|
patch_mmc_receive_id_default_to_127.patch (351 bytes)
Index: libs/midi++2/mmc.cc
===================================================================
--- libs/midi++2/mmc.cc (revision 5768)
+++ libs/midi++2/mmc.cc (working copy)
@@ -202,7 +202,7 @@
build_mmc_cmd_map ();
- _receive_device_id = 0;
+ _receive_device_id = 0x7f;
_send_device_id = 0x7f;
if ((parser = _port.input()) != 0) {
|
|
|
Updated patch attached. |
|
2009-10-13 02:12
|
patch_mmc_receive_id_default_to_127_updated.patch (1,160 bytes)
Index: 2.0-ongoing/libs/midi++2/mmc.cc
===================================================================
--- 2.0-ongoing/libs/midi++2/mmc.cc (revision 5768)
+++ 2.0-ongoing/libs/midi++2/mmc.cc (working copy)
@@ -202,7 +202,7 @@
build_mmc_cmd_map ();
- _receive_device_id = 0;
+ _receive_device_id = 0x7f;
_send_device_id = 0x7f;
if ((parser = _port.input()) != 0) {
Index: 2.0-ongoing/libs/ardour/ardour/configuration_vars.h
===================================================================
--- 2.0-ongoing/libs/ardour/ardour/configuration_vars.h (revision 5768)
+++ 2.0-ongoing/libs/ardour/ardour/configuration_vars.h (working copy)
@@ -36,7 +36,7 @@
CONFIG_VARIABLE (bool, send_mmc, "send-mmc", true)
CONFIG_VARIABLE (bool, mmc_control, "mmc-control", true)
CONFIG_VARIABLE (bool, midi_feedback, "midi-feedback", false)
-CONFIG_VARIABLE (uint8_t, mmc_receive_device_id, "mmc-receive-device-id", 0)
+CONFIG_VARIABLE (uint8_t, mmc_receive_device_id, "mmc-receive-device-id", 0x7f)
CONFIG_VARIABLE (uint8_t, mmc_send_device_id, "mmc-send-device-id", 0x7f)
CONFIG_VARIABLE (int32_t, initial_program_change, "initial-program-change", -1)
|
|
|
Assigned to Paul to take a look at the patch. Seablade |
|
|
Patch applied to 3.0. |
|
|
I removed the 3.0-beta1 target version from this bug as I have applied the patch to 3.0 so it should be fixed in 3.0. Can you confirm? |
|
|
Removing 3.0-beta1 target again; please add a note if this is still a problem with 3.0. Thanks! |
|
|
fixed in 3.0. case closed. |
|
|
fixed |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-10-03 17:13 | oofus | New Issue | |
| 2009-10-12 21:21 | petem | File Added: patch_mmc_receive_id_default_to_127.patch | |
| 2009-10-12 21:22 | petem | Note Added: 0006696 | |
| 2009-10-13 02:11 | petem | Note Edited: 0006696 | |
| 2009-10-13 02:12 | petem | File Added: patch_mmc_receive_id_default_to_127_updated.patch | |
| 2009-10-13 14:48 | seablade | Status | new => assigned |
| 2009-10-13 14:48 | seablade | Assigned To | => paul |
| 2009-10-13 14:48 | seablade | Note Added: 0006699 | |
| 2010-04-24 10:28 | cth103 | Category | bugs => bugs2 |
| 2010-04-24 10:31 | cth103 | Category | bugs2 => bugs |
| 2010-07-22 15:44 | oofus | Target Version | => 3.0-beta1 |
| 2010-07-25 23:55 | cth103 | Note Added: 0008646 | |
| 2010-07-25 23:55 | cth103 | cost | => 0.00 |
| 2010-07-25 23:55 | cth103 | Target Version | 3.0-beta1 => |
| 2010-08-16 21:28 | oofus | Target Version | => 3.0-beta1 |
| 2010-08-17 13:25 | cth103 | Note Added: 0008850 | |
| 2010-08-19 15:02 | cth103 | Status | assigned => feedback |
| 2010-08-28 01:02 | cth103 | Note Added: 0008920 | |
| 2010-08-28 01:02 | cth103 | Target Version | 3.0-beta1 => |
| 2010-09-17 20:45 | paul | Note Added: 0009087 | |
| 2010-09-17 20:45 | paul | Status | feedback => resolved |
| 2010-09-17 20:45 | paul | Resolution | open => fixed |
| 2010-10-17 13:31 | oofus | Note Added: 0009253 | |
| 2010-10-17 13:31 | oofus | Status | resolved => closed |
