View Issue Details

IDProjectCategoryView StatusLast Update
0002564ardourbugspublic2010-04-24 10:33
Reporterlincoln Assigned To 
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Summary0002564: Crash when loading a second session
DescriptionWhen loading a second session in Ardour 3.0 a crash occurs. This happens when the destructor to Ticker is called as a result of the first session emitting the GoingAway signal.

MidiClockTicker should be a singleton and should not be deleted when changing a session. The new session will take care of re-initialising the MidiClockTicker instace correctly.

I am attaching a small patch that addresses this issue.
TagsNo tags attached.

Activities

2009-02-23 00:30

 

ticker-delete_crash_fix.patch (655 bytes)   
 Index: libs/ardour/ardour/ticker.h
===================================================================
--- libs/ardour/ardour/ticker.h	(revision 4649)
+++ libs/ardour/ardour/ticker.h	(working copy)
@@ -43,7 +43,7 @@
 		const SMPTE::Time& transport_smpte) = 0;
 	
 	virtual void set_session(Session& s);
-	virtual void going_away() { _session = 0;  delete this; }
+	virtual void going_away() { _session = 0; }
 
 protected:
 	Session* _session;
@@ -72,7 +72,7 @@
 	
 	void set_session(Session& s);
 	void going_away() { _midi_port = 0; Ticker::going_away(); }
-	
+
 	/// slot for the signal session::MIDIClock_PortChanged
 	void update_midi_clock_port();

hansfbaier

2009-03-16 16:14

reporter   ~0005825

applied the patch, thanks!

lincoln

2009-03-30 23:39

reporter   ~0005848

This issue can be closed I guess.

seablade

2009-07-05 23:35

manager   ~0006366

Closing issue per OP request as it has been fixed;)

Issue History

Date Modified Username Field Change
2009-02-23 00:30 lincoln New Issue
2009-02-23 00:30 lincoln File Added: ticker-delete_crash_fix.patch
2009-03-16 16:14 hansfbaier Note Added: 0005825
2009-03-30 23:39 lincoln Note Added: 0005848
2009-07-05 23:35 seablade cost => 0.00
2009-07-05 23:35 seablade Note Added: 0006366
2009-07-05 23:35 seablade Status new => closed
2009-07-05 23:35 seablade Resolution open => fixed
2010-04-24 10:28 cth103 Category bugs => bugs2
2010-04-24 10:33 cth103 Category bugs2 => bugs