View Issue Details

IDProjectCategoryView StatusLast Update
0008943ardourbugspublic2022-08-09 19:50
Reporterjohne53 Assigned Topaul  
Status resolvedResolutionfixed 
PlatformMicrosoftOSWindowsOS Version10
Summary0008943: Strange pointer usage in 'libs'ardour''
DescriptionI'm repeatedly seeing crashes here when using the Cue Marker lane (in the Edit window). These translate to assertions if I make a Debug build here (with MSVC). I haven't tracked down all the problems but at least part of it is coming from code like this inside 'TriggerBox::fast_forward ()' :-

    CueEvents::const_iterator nxt_cue = c; ++nxt_cue;

    // Then statements like this (further down)
    c = nxt_cue;
    pos = c->time;

As you can see, there's no check to validate the 'c' object. It can easily be pointing to cues.end()
TagsNo tags attached.



2022-07-21 06:40

reporter   ~0026518

Sorry - one other thing... it's likely just something I'm not understanding but what's the significance of tests like this

    if (c->cue == INT32_MAX)

AFAICT we never set it to INT32_MAX so what would cause it to be set like that?


2022-08-09 19:50

administrator   ~0026535

INT32_MAX == CueRecord::stop_all

code has been changed.

Issue History

Date Modified Username Field Change
2022-07-21 06:31 johne53 New Issue
2022-07-21 06:40 johne53 Note Added: 0026518
2022-08-09 19:50 paul Assigned To => paul
2022-08-09 19:50 paul Status new => resolved
2022-08-09 19:50 paul Resolution open => fixed
2022-08-09 19:50 paul Note Added: 0026535