0008943: Strange pointer usage in 'libs'ardour'triggerbox.cc'

ID	Project	Category	View Status	Date Submitted	Last Update

0008943	ardour	bugs	public	2022-07-21 06:31	2022-07-21 06:40

Reporter	johne53	Assigned To
Priority	urgent	Severity	major	Reproducibility	always
Status	new	Resolution	open
Platform	Microsoft	OS	Windows	OS Version	10

Summary	0008943: Strange pointer usage in 'libs'ardour'triggerbox.cc'
Description	I'm repeatedly seeing crashes here when using the Cue Marker lane (in the Edit window). These translate to assertions if I make a Debug build here (with MSVC). I haven't tracked down all the problems but at least part of it is coming from code like this inside 'TriggerBox::fast_forward ()' :- CueEvents::const_iterator nxt_cue = c; ++nxt_cue; // Then statements like this (further down) c = nxt_cue; pos = c->time; As you can see, there's no check to validate the 'c' object. It can easily be pointing to cues.end()
Tags	No tags attached.

Date Modified	Username	Field	Change
2022-07-21 06:31	johne53	New Issue
2022-07-21 06:40	johne53	Note Added: 0026518

johne53 2022-07-21 06:40 reporter ~0026518	Sorry - one other thing... it's likely just something I'm not understanding but what's the significance of tests like this if (c->cue == INT32_MAX) AFAICT we never set it to INT32_MAX so what would cause it to be set like that?