0004817: Probably unintentional switch statement fall-through

ID	Project	Category	View Status	Date Submitted	Last Update

0004817	ardour	bugs	public	2012-04-05 00:16	2020-04-19 20:16

Reporter	ahurst	Assigned To	cth103
Priority	normal	Severity	trivial	Reproducibility	have not tried
Status	closed	Resolution	fixed
Product Version	3.0-beta3
Target Version	3.0

Summary	0004817: Probably unintentional switch statement fall-through
Description	Medium impact static analysis bug: Missing break in switch at libs/ardour/session_vst.cc:249 and libs/ardour/session_vst.cc:260. Probably unintentional based on the rest of the structure.
Additional Information	247 * Missing break in switch (MISSING_BREAK) 248 case audioMasterOfflineStart: 249 SHOW_CALLBACK ("amc: audioMasterOfflineStart\n"); 250 case audioMasterOfflineRead: 251 SHOW_CALLBACK ("amc: audioMasterOfflineRead\n"); 252 // ptr points to offline structure, see below. return 0: error, 1 ok 253 return 0; 254 255 case audioMasterOfflineWrite: 256 SHOW_CALLBACK ("amc: audioMasterOfflineWrite\n"); 257 // same as read 258 return 0; 259 * Missing break in switch (MISSING_BREAK) 260 case audioMasterOfflineGetCurrentPass: 261 SHOW_CALLBACK ("amc: audioMasterOfflineGetCurrentPass\n"); The above case falls through to this one. 262 case audioMasterOfflineGetCurrentMetaPass: 263 SHOW_CALLBACK ("amc: audioMasterOfflineGetCurrentMetaPass\n"); 264 return 0; 265
Tags	No tags attached.

Date Modified	Username	Field	Change
2012-04-05 00:16	ahurst	New Issue
2012-04-05 01:06	cth103	cost	=> 0.00
2012-04-05 01:06	cth103	Target Version	=> 3.0 beta4
2012-04-05 01:06	cth103	Additional Information Updated
2012-04-11 23:24	cth103	Note Added: 0013115
2012-04-11 23:24	cth103	Status	new => resolved
2012-04-11 23:24	cth103	Resolution	open => fixed
2012-04-11 23:24	cth103	Assigned To	=> cth103
2012-05-23 15:08	cth103	Target Version	3.0 beta4 => 3.0
2020-04-19 20:16	system	Note Added: 0023026
2020-04-19 20:16	system	Status	resolved => closed

cth103 2012-04-11 23:24 administrator ~0013115	SVN 11924.

system 2020-04-19 20:16 developer ~0023026	Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved.