View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004814 | ardour | bugs | public | 2012-04-04 23:54 | 2020-04-19 20:16 |
| Reporter | ahurst | Assigned To | cth103 | ||
| Priority | normal | Severity | trivial | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.0-beta3 | ||||
| Target Version | 3.0 | ||||
| Summary | 0004814: Dereferencing pointer causes crash for unexpected XML input | ||||
| Description | Medium impact static analysis bug: Dereferencing a pointer that might be null at: libs/ardour/audio_track_importer.cc:278. A crash would happen if the "id" tag were missing from a line. Better to handle. | ||||
| Additional Information | *** Function "XMLNode::property(char const *)" may return null (it is checked 219 out of 254 times). *** Dereferencing a pointer that might be null "ds_node->property("id")" when calling "XMLProperty::set_value(std::string const &)". 278 ds_node->property ("id")->set_value (new_ds_id.to_s()); | ||||
| Tags | No tags attached. | ||||
|
|
Same issue at: libs/ardour/audio_track_importer.cc:250 libs/ardour/audio_playlist_importer.cc:181 gtk2_ardour/sfdb_ui.cc:887 (the other child nodes are checked) gtk2_ardour/sfdb_freesound_mootcher.cc:264 |
|
|
SVN 11794. Thanks for all these reports! |
|
|
Does SVN 11794 fix all these issues or just the first reported one ? |
|
|
Well spotted, remainder fixed in SVN 11894. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-04-04 23:54 | ahurst | New Issue | |
| 2012-04-05 00:01 | ahurst | Note Added: 0013079 | |
| 2012-04-05 01:12 | cth103 | cost | => 0.00 |
| 2012-04-05 01:12 | cth103 | Target Version | => 3.0 beta4 |
| 2012-04-05 01:23 | cth103 | Note Added: 0013083 | |
| 2012-04-05 01:23 | cth103 | Status | new => resolved |
| 2012-04-05 01:23 | cth103 | Resolution | open => fixed |
| 2012-04-05 01:23 | cth103 | Assigned To | => cth103 |
| 2012-04-05 10:59 | oofus | Note Added: 0013084 | |
| 2012-04-05 10:59 | oofus | Status | resolved => feedback |
| 2012-04-05 10:59 | oofus | Resolution | fixed => reopened |
| 2012-04-11 10:51 | cth103 | Note Added: 0013112 | |
| 2012-04-11 10:51 | cth103 | Status | feedback => resolved |
| 2012-04-11 10:51 | cth103 | Resolution | reopened => fixed |
| 2012-05-23 15:08 | cth103 | Target Version | 3.0 beta4 => 3.0 |
| 2020-04-19 20:16 | system | Note Added: 0023023 | |
| 2020-04-19 20:16 | system | Status | resolved => closed |
