View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002601 | ardour | bugs | public | 2009-03-28 21:17 | 2010-04-24 10:33 |
| Reporter | oofus | Assigned To | cth103 | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Dell latitude D830 core2duo | OS | Mandriva | OS Version | 2009.0 |
| Summary | 0002601: 'popup region editor' shows incorrect region end time. It's one sample too big | ||||
| Description | 'popup region editor' shows incorrect region end time. It's one sample too big. Calculation should be 'start + lengh -1'. Guessing it's being done as 'start + lengh' | ||||
| Steps To Reproduce | right click on a region and select 'popup region editor'. Right click on each clock and set them to 'samples'. End will be off by one. | ||||
| Tags | No tags attached. | ||||
|
|
checked in 2.x-ongoing (near as damn it 2.8) and this issue is there also. |
|
|
hmm.. it is being done as start + length. Is this definitely wrong? |
|
|
Yes. Imagine a region 10 samples long that starts on 100 samples (time line position). Count 10 samples from 100. 100, 101, 102, 103, 104, 105, 106, 107, 108, 109. The last sample of the region is actually at 109 (time line position). It should be start + length - 1. |
|
|
Ah yes, ok. The attached patch should fix this for 3.0. It also cleans up a few minor things in that dialog. I'll patch when I get my SSH keys for SVN working. |
|
|
thanks. I wonder if there are any other places in the code (not just user info dialogues etc) where this has been got wrong. Maybe an issue with audio processing ? Or maybe not relevant. |
|
|
There may well be. This patch changes the semantics of Region::trim_end() so any caller of that might be surprised at the new behaviour. |
|
2009-04-27 22:43
|
|
|
|
This should be fixed in A3 SVN revision 5813. |
|
|
see notes |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-03-28 21:17 | oofus | New Issue | |
| 2009-03-28 21:33 | oofus | Note Added: 0005845 | |
| 2009-04-27 18:40 | cth103 | Note Added: 0005910 | |
| 2009-04-27 19:05 | oofus | Note Added: 0005912 | |
| 2009-04-27 21:24 | cth103 | File Added: 2601.patch | |
| 2009-04-27 21:25 | cth103 | Note Added: 0005917 | |
| 2009-04-27 21:36 | oofus | Note Added: 0005918 | |
| 2009-04-27 21:53 | cth103 | File Added: 2601.patch.2 | |
| 2009-04-27 21:54 | cth103 | Note Added: 0005920 | |
| 2009-04-27 22:43 | cth103 | File Deleted: 2601.patch | |
| 2009-04-27 22:43 | cth103 | File Deleted: 2601.patch.2 | |
| 2009-04-27 22:43 | cth103 | File Added: 2601.patch.3 | |
| 2009-10-19 18:51 | cth103 | Relationship added | related to 0002602 |
| 2009-10-20 01:05 | cth103 | cost | => 0.00 |
| 2009-10-20 01:05 | cth103 | Note Added: 0006754 | |
| 2009-10-20 01:05 | cth103 | Status | new => resolved |
| 2009-10-20 01:05 | cth103 | Resolution | open => fixed |
| 2009-10-20 01:05 | cth103 | Assigned To | => cth103 |
| 2009-10-30 00:00 | oofus | Status | resolved => feedback |
| 2009-10-30 00:00 | oofus | Resolution | fixed => reopened |
| 2009-10-30 00:00 | oofus | Note Added: 0006987 | |
| 2009-10-30 00:00 | oofus | Status | feedback => closed |
| 2009-10-30 00:00 | oofus | Resolution | reopened => fixed |
| 2010-04-24 10:28 | cth103 | Category | bugs => bugs2 |
| 2010-04-24 10:33 | cth103 | Category | bugs2 => bugs |
