0004409: [PATCH] When deselecting a plug-in button, it also becomes inactive

ID	Project	Category	View Status	Date Submitted	Last Update

0004409	ardour	other	public	2011-10-30 16:09	2011-11-01 09:26

Reporter	royvegard	Assigned To
Priority	normal	Severity	minor	Reproducibility	N/A
Status	resolved	Resolution	fixed
Target Version	3.0-beta1

Summary	0004409: [PATCH] When deselecting a plug-in button, it also becomes inactive
Description	This patch fixes the deactivation (dark led and gray text) of the plug-in buttons when they are deselected.
Steps To Reproduce	1. Click the text part of any activated (not bypassed) plug-in in the mixer strip. 2. Click the text part of another plug-in in the same channel or click on the black area, to deselect the plug-in button. The button will indicate that the plug-in is not active, i.e. the led is dark and text is gray.
Tags	No tags attached.

2011-10-30 16:09	plug_in_button.patch (406 bytes) diff --git a/gtk2_ardour/processor_box.cc b/gtk2_ardour/processor_box.cc index ce33f61..eda5658 100644 --- a/gtk2_ardour/processor_box.cc +++ b/gtk2_ardour/processor_box.cc @@ -162,6 +162,8 @@ ProcessorEntry::set_visual_state (Gtk::StateType t) break; case Gtk::STATE_NORMAL: + _button.unset_visual_state (); + break; default: _button.unset_visual_state (); _button.unset_active_state (); plug_in_button.patch (406 bytes)

nettings 2011-11-01 09:24 manager ~0011848	looks like paul didn't see your patch unfortunately, but he fixed the issue nonetheless. works for me so i'm closing this, please shout if you run into further issues.

Date Modified	Username	Field	Change
2011-10-30 16:09	royvegard	New Issue
2011-10-30 16:09	royvegard	File Added: plug_in_button.patch
2011-10-30 17:30	cth103	cost	=> 0.00
2011-10-30 17:30	cth103	Target Version	=> 3.0-beta1
2011-11-01 09:24	nettings	Note Added: 0011848
2011-11-01 09:26	nettings	Status	new => resolved
2011-11-01 09:26	nettings	Resolution	open => fixed