MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0007110ardourbugspublic2016-11-13 19:032016-11-14 15:10
Reportertimbyr 
Assigned Tonmains 
PrioritynormalSeveritycrashReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version5.X git (version in description) 
Target VersionFixed in Version5.X git (version in description) 
Summary0007110: Session with selected midi notes in 5.4.320 crashes when opened with 5.4
DescriptionI know that we don't guarantee backwards Session file compatibility but if this is easy enough to fix/revert/add compatibility, I think we should do so.

It looks like this issue was introduced recently with commit 9698f16a
TagsNo tags attached.
Attached Filestxt file icon 5.4-crash-with-selected-midi-notes.bt.txt [^] (33,614 bytes) 2016-11-13 19:33 [Show Content]

- Relationships

-  Notes
(0018958)
x42 (administrator)
2016-11-13 19:10

Can you get a backtrace? Is it as simple as

Selection::set_state ()
{
  ...
  XMLProperty const * prop_id = (*ci)->property (X_("id"));
  Evoral::event_id_t id = atoi(prop_id->value());
  ...
}

and prop_id is NULL when loading a 5.4.0 session?
(0018959)
x42 (administrator)
2016-11-13 19:15
edited on: 2016-11-13 19:17

Potential fix in 5.4-334-g6794a83

since "id" not a PBD::ID but an Evoral::event_id_t I think we should change the identifier-name and not re-use "id" in the XML.

(0018961)
timbyr (developer)
2016-11-13 19:34

Sorry, backtrace from 5.4 build uploaded.

I'll test potential fix now.
(0018962)
x42 (administrator)
2016-11-13 19:39

Oh, that's the other way 'round :) I've fixed backwards compat: A session saved in 5.4.0 w/selection -> open in 5.4-git.

You want forward compatibility :(
(0018963)
timbyr (developer)
2016-11-13 19:42

I agree about not using "id" as the identifier name, perhaps "note-id" or "event-id" (unless that may cause complications later on)
(0018964)
timbyr (developer)
2016-11-13 19:52

In this case I would prefer if a Session with midi notes selected and saved in 5.5 doesn't crash when opened in 5.4.

We could strictly stick to a no "forward" compatiblity policy but I think this may annoy people if they are sharing and working on Sessions between 5.5 and 5.4 versions.

Even if this doesn't get fixed, I thought it necessary to at least report the issue.
(0018965)
x42 (administrator)
2016-11-13 20:07

Changing the top-level identifier ("MIDINote") to something else would work.
In that case selection is simply lost when going between 5.4 and upcoming 5.5
(0018966)
timbyr (developer)
2016-11-13 20:12

Losing selection state when opening a Session in an earlier program version *is* totally acceptable IMO.
(0018967)
nick_m (reporter)
2016-11-14 08:49

this should be fixed by 0b2ae7dad
(0018970)
timbyr (developer)
2016-11-14 15:10

Tested with c16eb83f applied. Should be resolved as of nightly build >= 5.4.341

Now opening a Session created in version >= 5.4.341 with 5.4 only selection information is lost, no crash.

- Issue History
Date Modified Username Field Change
2016-11-13 19:03 timbyr New Issue
2016-11-13 19:03 timbyr Status new => assigned
2016-11-13 19:03 timbyr Assigned To => nmains
2016-11-13 19:10 x42 Note Added: 0018958
2016-11-13 19:15 x42 Note Added: 0018959
2016-11-13 19:17 x42 Note Edited: 0018959 View Revisions
2016-11-13 19:33 timbyr File Added: 5.4-crash-with-selected-midi-notes.bt.txt
2016-11-13 19:34 timbyr Note Added: 0018961
2016-11-13 19:39 x42 Note Added: 0018962
2016-11-13 19:42 timbyr Note Added: 0018963
2016-11-13 19:52 timbyr Note Added: 0018964
2016-11-13 20:07 x42 Note Added: 0018965
2016-11-13 20:12 timbyr Note Added: 0018966
2016-11-14 08:49 nick_m Note Added: 0018967
2016-11-14 15:10 timbyr Note Added: 0018970
2016-11-14 15:10 timbyr Status assigned => resolved
2016-11-14 15:10 timbyr Fixed in Version => 5.X git (version in description)
2016-11-14 15:10 timbyr Resolution open => fixed


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker