View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007105 | ardour | bugs | public | 2016-11-12 22:11 | 2020-04-19 20:18 |
| Reporter | unfa | Assigned To | timbyr | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Platform | GNU/Linux AMD 64 | OS | Linux Mint | OS Version | 18 KDE5 |
| Product Version | 5.4 | ||||
| Summary | 0007105: Linked MIDI regions shift notes when resizing | ||||
| Description | I think I know why this is happening. When resizing linked MIDI regions - the regions is increasing in size so that the first note has more space between itself and the start of the region - room where new notes can be inserted. The problem is, the other linked regions should compensate for that to keep their notes in place - instead they shift their notes. | ||||
| Steps To Reproduce | 1. Create MIDI region on a MIDI track and put some notes in it. 2. Duplicate that region onto the same MIDI track (drag & drop while holding Ctrl) 3. Resize the duplicated region's start to the left. 4. The original MIDI regions's notes will shift to the right - breaking sync with the track. | ||||
| Tags | No tags attached. | ||||
|
|
I can confirm this issue in 5.4 and 5.4.320 nightly. This behaviour seems incorrect to me, the offset of the MIDI events from region start within a region should be independent even for linked regions if that is possible or if not then region should automatically become unlinked. I can't think of a situation where the current behaviour would ever be intentional. I also notice that it seems to increase the offset if you move the region start earlier on the timeline but it won't change the offset back when you move the region start position back to the original position. |
|
|
this is due to the trim operation extending the source start to the region start. see MidiRegion::fix_negative_start() it should be possible to remove this. |
|
|
so if se reset the start for all regions using the same source, it should work. i think the problem is that the other regions don't know that their source has been resized. |
|
|
this should be fixed by commit e8b5b4fcf3. can you test? thanks |
|
|
It seems to work as expected but I have noticed and issue with undo. If you copy (linked) a MIDI region and trim/move the start position to the left past original region start then the first region doesn't change as it used to, but undo at that point will change note offset in the original region. |
|
|
this bug only appears if a region that uses the same source is on another playlist. it should be fixed by commit a445e8277640 please test region start trim undo for audio and midi regions and combinations of multiple track region start trims. |
|
|
There still seems to be an issue with undo after commit, I've attached a video to capture what I'm seeing. |
|
|
|
|
|
does commit 16089bff96a13b8 fix it? thanks |
|
|
It now seems to work as expected without any issues after a little testing in version 5.8.76(16089bff96) I'll do some further testing and if I can't find any issues with it I'll mark it as resolved. |
|
|
I spent a bit more time testing this (with 5.8.116) and it does seem to always work correctly with undo/redo etc. Marking as resolved. |
|
|
Issue has been closed automatically, by Trigger Close Plugin. Feel free to re-open with additional information if you think the issue is not resolved. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-11-12 22:11 | unfa | New Issue | |
| 2016-11-13 00:21 | timbyr | Note Added: 0018946 | |
| 2016-11-13 00:21 | timbyr | Status | new => confirmed |
| 2016-11-16 12:13 | nick_m | Note Added: 0018973 | |
| 2016-11-16 12:28 | nick_m | Note Added: 0018974 | |
| 2017-03-04 00:35 | nick_m | Note Added: 0019461 | |
| 2017-03-04 00:52 | timbyr | Status | confirmed => feedback |
| 2017-03-05 01:03 | timbyr | Note Added: 0019483 | |
| 2017-03-05 14:04 | nick_m | Note Added: 0019487 | |
| 2017-03-06 00:19 | timbyr | Note Added: 0019490 | |
| 2017-03-06 00:19 | timbyr | File Added: Ardour-5.8.73-test-bug-7105.webm | |
| 2017-03-06 04:53 | nick_m | Note Added: 0019493 | |
| 2017-03-06 06:43 | timbyr | Note Added: 0019494 | |
| 2017-03-11 11:34 | timbyr | Note Added: 0019522 | |
| 2017-03-11 11:34 | timbyr | Status | feedback => resolved |
| 2017-03-11 11:34 | timbyr | Resolution | open => fixed |
| 2017-03-11 11:34 | timbyr | Assigned To | => timbyr |
| 2020-04-19 20:18 | system | Note Added: 0023670 | |
| 2020-04-19 20:18 | system | Status | resolved => closed |
