MantisBT

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0006828ardourbugspublic2016-03-19 06:292016-12-19 15:11
Reporterventosus 
Assigned Topaul 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformanyOSanyOS Versionany
Product Version4.7 
Target VersionFixed in Version 
Summary0006828: Fix minimum/maximum discovery for integer params
DescriptionAs 'load_parameter_descriptor' is both used for lv2:ControlPorts and
lv2:Parameters, it needs to also be able to discover integer minimum
and maximum, as lv2:Parameters can be of type atom:Int/Long.
Steps To ReproduceDefine an integer parameter in a plugin's *.ttl and Ardour won't be able to discover its minimum/maximum correctly and will fall back to range [0, 1].

esp:through_zone_mask
  a lv2:Parameter ;
  rdfs:label "Zone Mask" ;
  rdfs:range atom:Int ;
  lv2:minimum 0 ;
  lv2:maximum 256 .

[...]
  patch:writable
    esp:through_zone_mask ;
[...]
Additional InformationPatch attached.
TagsNo tags attached.
Attached Filespatch file icon 0001-Fix-minimum-maximum-discovery-for-integer-params.patch [^] (1,786 bytes) 2016-03-19 06:29 [Show Content]

- Relationships

-  Notes
(0019135)
ventosus (reporter)
2016-12-09 05:22

update: still an issue in 5.5
(0019181)
x42 (administrator)
2016-12-19 14:51

a quick check on lilv's version history indicates that
lilv_node_is_float() is only available since 1e7b27c7b322476c437a8524cff4a88245c5efbf Fri Apr 29 19:30:30 2011

Ardour's minium requirement is 0.2.0, so this patch needs some #ifdef
or we need to bump the min version, which is sensible.

drobilla?
(0019189)
x42 (administrator)
2016-12-19 15:07

sorry, my bad. ardour needs lilv 0.14.0 (or later), it's sratom-0 that's at 0.2.0.

merge away
(0019190)
paul (administrator)
2016-12-19 15:11

manually applied with patch(1) since git-apply fails. thanks!
(0019191)
paul (administrator)
2016-12-19 15:11

see notes.

- Issue History
Date Modified Username Field Change
2016-03-19 06:29 ventosus New Issue
2016-03-19 06:29 ventosus File Added: 0001-Fix-minimum-maximum-discovery-for-integer-params.patch
2016-12-09 05:22 ventosus Note Added: 0019135
2016-12-19 14:51 x42 Note Added: 0019181
2016-12-19 15:07 x42 Note Added: 0019189
2016-12-19 15:11 paul Note Added: 0019190
2016-12-19 15:11 paul Note Added: 0019191
2016-12-19 15:11 paul Status new => resolved
2016-12-19 15:11 paul Resolution open => fixed
2016-12-19 15:11 paul Assigned To => paul


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker