View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002342 | ardour | bugs | public | 2008-07-10 22:04 | 2011-08-16 11:13 |
| Reporter | colinf | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002342: Resizing track while editing in track name edit box hangs Ardour | ||||
| Description | If you start typing into the track name edit box box, and then, with the focus still in the edit box, re-size the track so that the edit box disappears, Ardour will hang. | ||||
| Additional Information | Attached a small patch to prevent the track name edit box being hidden when the track is resized, if it has focus and the user is in the middle of editing the track name. This avoids the problem. | ||||
| Tags | No tags attached. | ||||
|
2008-07-10 22:04
|
resize-while-renaming-track.patch (652 bytes)
Index: gtk2_ardour/route_time_axis.cc
===================================================================
--- gtk2_ardour/route_time_axis.cc (revision 3584)
+++ gtk2_ardour/route_time_axis.cc (working copy)
@@ -745,9 +745,14 @@
} else {
hide_meter ();
- hide_name_entry ();
- show_name_label ();
+ // don't hide name_entry if the user is editing it: this might
+ // look a bit funny, but it's better than locking up...
+ if (!name_entry.has_focus() || name_entry.get_text() == _route->name()) {
+ hide_name_entry ();
+ show_name_label ();
+ }
+
gm.get_gain_slider().hide();
mute_button->hide();
solo_button->hide();
|
|
2008-11-20 20:25
|
resize-while-renaming-track-4225.patch (788 bytes)
Index: gtk2_ardour/route_time_axis.cc
===================================================================
--- gtk2_ardour/route_time_axis.cc (revision 4224)
+++ gtk2_ardour/route_time_axis.cc (working copy)
@@ -758,9 +758,17 @@
} else {
hide_meter ();
- hide_name_entry ();
- show_name_label ();
+ if (!name_entry.has_focus() || name_entry.get_text() == _route->name()) {
+ // only hide name_entry if the user is not editing it:
+ // this might look a bit funny, but it's better than
+ // locking up...
+ hide_name_entry ();
+ show_name_label ();
+ }
+ // else possibly it'd be better to accept the changed name here
+ // as if the user hit enter before shrinking the track.
+
gm.get_gain_slider().hide();
mute_button->hide();
solo_button->hide();
|
|
|
Here's the patch updated against svn 4225 (and with a comment about how it could be done better, too). |
|
|
Unable to reproduce on Ardour 2.7, Mac OS X Intel, however assigning to Paul to check the patch in case he can reproduce it on Linux. Seablade |
|
|
fixed at rev 4249 with a variation on colin's patch - rather than not hiding the name entry, we (a) if necessary handle the name change and then (b) move focus away from it to the track's LHS control "box". tested and confirmed working. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-07-10 22:04 | colinf | New Issue | |
| 2008-07-10 22:04 | colinf | File Added: resize-while-renaming-track.patch | |
| 2008-11-20 20:25 | colinf | File Added: resize-while-renaming-track-4225.patch | |
| 2008-11-20 20:26 | colinf | Note Added: 0005251 | |
| 2008-11-24 09:36 | seablade | Status | new => assigned |
| 2008-11-24 09:36 | seablade | Assigned To | => paul |
| 2008-11-24 09:36 | seablade | Note Added: 0005308 | |
| 2008-11-25 11:38 | paul | cost | => 0.00 |
| 2008-11-25 11:38 | paul | Status | assigned => resolved |
| 2008-11-25 11:38 | paul | Resolution | open => fixed |
| 2008-11-25 11:38 | paul | Note Added: 0005363 | |
| 2010-04-24 10:28 | cth103 | Category | bugs => bugs2 |
| 2010-04-24 10:32 | cth103 | Category | bugs2 => bugs |
| 2011-08-16 11:13 | colinf | Status | resolved => closed |
