View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002339 | ardour | bugs | public | 2008-07-10 17:44 | 2011-08-16 11:12 |
| Reporter | colinf | Assigned To | seablade | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002339: Resizing automation tracks causes track header controls to disappear | ||||
| Description | If you shrink a automation track with the new track sizing handles until the controls in the header are hidden, resizing the track larger won't cause the controls to become visible again. The only way to get them to re-appear is to choose "Small" or "Smaller" from the track header context menu, and then choose "Normal" (or larger). | ||||
| Additional Information | Attached a minimal patch to correct this. This simply hides all controls when the height of the automation track becomes less than hNormal, and shows them all when it becomes greater than or equal to hNormal. Perhaps the upper row of controls should only disappear when height is less than hSmaller, analogous with audio tracks, but I haven't implemented that just yet. | ||||
| Tags | No tags attached. | ||||
|
2008-07-10 17:44
|
fix-disappearing-automation-track-header-controls.patch (707 bytes)
Index: gtk2_ardour/automation_time_axis.cc
===================================================================
--- gtk2_ardour/automation_time_axis.cc (revision 3577)
+++ gtk2_ardour/automation_time_axis.cc (working copy)
@@ -302,7 +302,7 @@
AutomationTimeAxisView::set_height (uint32_t h)
{
bool changed = (height != (uint32_t) h);
- bool changed_between_small_and_normal = ( (h == hSmall || h == hSmaller) ^ (height == hSmall || height == hSmaller) );
+ bool changed_between_small_and_normal = ( (height < hNormal && h >= hNormal) || (height >= hNormal || h < hNormal) );
TimeAxisView* state_parent = get_parent_with_state ();
XMLNode* xml_node = state_parent->get_child_xml_node (_state_name);
|
|
|
This seems to have been fixed in a different way in svn 3722. I think the patch here is perhaps slightly better, since it doesn't continually re-show the controls every time the track size changes, but it's not really critical. |
|
|
Appears to be fixed in recent versions of Ardour, setting status to resolved. If this problem persist in recent versions of ardour for the OP please post a note back and I will reopen the issue. Seablade |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-07-10 17:44 | colinf | New Issue | |
| 2008-07-10 17:44 | colinf | File Added: fix-disappearing-automation-track-header-controls.patch | |
| 2008-09-16 10:06 | colinf | Note Added: 0005137 | |
| 2008-11-21 19:43 | seablade | cost | => 0.00 |
| 2008-11-21 19:43 | seablade | Status | new => resolved |
| 2008-11-21 19:43 | seablade | Resolution | open => fixed |
| 2008-11-21 19:43 | seablade | Assigned To | => seablade |
| 2008-11-21 19:43 | seablade | Note Added: 0005260 | |
| 2010-04-24 10:28 | cth103 | Category | bugs => bugs2 |
| 2010-04-24 10:32 | cth103 | Category | bugs2 => bugs |
| 2011-08-16 11:12 | colinf | Status | resolved => closed |
